Validate greater than or less than other field [#1783808]

"must equal an other field" and "can not equal an other field" should be generalized to also being able to check for "greater than (or equal to) other field" and "less than (or equal to) other field". This should work with dates so that one can check that end dates are after start dates.

Comment	File	Size	Author
#7	webform_validation_compare_1783808.patch	3.55 KB	liam morland
#5	webform_validation_compare_1783808.patch	3.54 KB	liam morland
#3	webform_validation_compare_1783808.patch	3.46 KB	liam morland
#2	webform_validation_compare_1783808.patch	3.87 KB	liam morland

Comments

Comment #1

liam morland

English

Ontario, CA 🇨🇦

commented 13 September 2012 at 16:28

Project:	Clientside Validation	» Webform Validation
Version:	7.x-1.x-dev	» 7.x-1.1
Component:	Webform Validation	» Validation rules

Sorry, I meant to put this on the Webform Validation queue.

Comment #2

liam morland

English

Ontario, CA 🇨🇦

commented 18 September 2012 at 19:29

Status:

Active

» Needs review

Status	File	Size
new	webform_validation_compare_1783808.patch	3.87 KB

Patch implementing this feature.

Comment #3

liam morland

English

Ontario, CA 🇨🇦

commented 18 September 2012 at 20:46

Status	File	Size
new	webform_validation_compare_1783808.patch	3.46 KB

Updated version uses custom error messages.

Comment #4

svendecabooter

he/him

Dutch

Gent

commented 10 December 2012 at 19:27

Status:

Needs review

» Needs work

Thanks for the new validation rule. It's looking good on first sight.

Some remarks:

Is there a use case for enabling this rule on the 'email' and 'hidden' component? Don't see how an email address could be greater than another?
Related: did you test with all component types? I checked date, time & textfield for now.
Might need some explicit documentation that it's the first checked component being compared to the second, using the entered operator. As this might not be crystal clear on first sight (though it's pretty logical)

Other than that I don't see any issues with it, so when those are adressed we might go ahead and commit it.

Note to self: patch also applies on 6.x branch by the way.

Comment #5

liam morland

English

Ontario, CA 🇨🇦

commented 10 December 2012 at 20:30

Status:

Needs work

» Needs review

Status	File	Size
new	webform_validation_compare_1783808.patch	3.54 KB

I think I left in all the component types because you never know what someone might want to be able to do. A comparison with a hidden could be used to enforce a number in a range, for example.

I did not individually test all component types. I figured they all work about the same. I tested time and date separately because they have different code execution paths.

I have attached a patch with improved help text.