If you go to a taxonomy feed, for instance taxonomy/term/1/feed it shows a broken page instead of a RSS feed.

Looking at taxonomy_term_feed() function, it seems that it's missing the "return" at the end of the function.

CommentFileSizeAuthor
#3 taxonomy-feed_page-1784226-2-test-only.patch678 byteslucascaro
#3 taxonomy-feed_page-1784226-2-test+fix.patch1.19 KBlucascaro
#1 taxonomy-feed_page-1784226-1.patch545 bytesjavi-er

Comments

javi-er’s picture

javi-er commented
StatusFileSize
new taxonomy-feed_page-1784226-1.patch545 bytes

Attached it's a patch that adds the missing "return"

javi-er’s picture

javi-er commented
Status: Active » Needs review
lucascaro’s picture

lucascaro commented
StatusFileSize
new taxonomy-feed_page-1784226-2-test+fix.patch1.19 KB
new taxonomy-feed_page-1784226-2-test-only.patch678 bytes

Great catch!

I've added a test-only patch to illustrate the issue.
Cheers.

Status: Needs review » Needs work

The last submitted patch, taxonomy-feed_page-1784226-2-test+fix.patch, failed testing.

javi-er’s picture

javi-er commented
Status: Needs work » Needs review

Changing to "needs review".

lucascaro’s picture

lucascaro commented

Re-testing the patch worked. This is a one-line bug that got introducing when moved from print to return on node_feed and there were no tests for the taxonomy feed page.

I'd RTBC this patch If the tests are ok, but I'm interested on feedback about the test, and if it's the best way to test this bug.

5t4rdu5t’s picture

5t4rdu5t commented

I've tested the patch again and it solves the issue.

5t4rdu5t’s picture

5t4rdu5t commented
Status: Needs review » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Looks reasonable to me. Committed/pushed to 8.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

gramar