Download & Extend
Feeds » Issues

FeedsTermProcessor existingEntityId doesn't honour id column in feeds_item

Posted by stefan.norman on September 14, 2012 at 8:52am
Project:Feeds
Version:7.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

I have two similar term importers set up. They import to two different vocabularies and both are using GUID as unique identifier.
Problem is that the TermProcessor is not checking the GUID corrctly. The function existingEntityId(FeedsSource $source, FeedsParserResult $result) only checks on feeds_item.entity_type='taxonomy_term'.
It should also check on feeds_item.id='[importer ID]'.

Login or register to post comments

Comments

#1

Posted by stefan.norman on September 14, 2012 at 9:09am
Status:active» needs review

Here's a patch that solves my problem.

AttachmentSizeStatusTest resultOperations
Feeds-TermProcessor_existingEntityId_guid_importerid-1784436-1.patch676 bytesIgnored: Check issue status.NoneNone

#2

Posted by twistor on September 20, 2012 at 7:09pm
Version:7.x-2.0-alpha5» 7.x-2.x-dev
Component:Feeds Import» Code

Hrm... This is odd. The guid is checked correctly in FeedsProcessor, it should not get checked again. I have to do some research to see why this code is here.

#3

Posted by twistor on September 20, 2012 at 8:30pm

The change comes from #1152940: Feeds term import with hierarchy and weight.

#4

Posted by twistor on September 26, 2012 at 2:40am
Assigned to:stefan.norman» Anonymous
Status:needs review» fixed

Should be fixed in http://drupalcode.org/project/feeds.git/commit/d2d11d2.

#5

Posted by stefan.norman on September 26, 2012 at 7:55am

Thanks twistor, I've tested it at my end and works perfectly in my setup.

#6

Posted by System Message on October 10, 2012 at 8:01am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here