Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.The link generated has a non urlencoded ampersand, which results in invalid xhtml.
google_fonts_api.module
line 92:
$url = $base . implode('|', $families) . '&subset=' . implode(',', $subsets);
change to:
$url = $base . implode('|', $families) . '&subset=' . implode(',', $subsets);
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | fontyourface-Link_to_Google_fonts_results_in_invalid_xhtml-1784734-2.patch | 1006 bytes | Drave Robber |
Comments
Comment #1
Drave Robber commentedUrlencoded ampersand seems to work. However, Google has its own notion of what is valid and what is not. With some Google APIs (e.g. 'old' Image Charts API), one needs to encode _parts_ of the URL. Hence, this will need some testing.
Comment #2
Drave Robber commentedProposed change does not break anything and makes the markup pass http://validator.w3.org/check
Patch attached.
(On a side note, this issue does not affect 7.x-2.x)
Comment #3
castawaybcn commentedPatch worked perfectly for me. Remember to clean your caches though.
Thanks a lot for this.
Comment #4
BarisW commentedLooks good!
Comment #5
Drave Robber commentedCommitted.
(credited to madlee as the initial report was clear enough as to what needs to be done, even if there was no patch)
Comment #6
Drave Robber commented(fixed)
Comment #7.0
(not verified) commentedtypo