Token dialog

Marked #1854546: have token_tree use the dialog as a duplicate of this issue. Looks good and assigning to myself to commit.

Any update? Works for me too, although a collapsible fieldset is probably no longer needed as a container. The link can perhaps be placed in the description of the main fieldset.

Maybe the fieldset could be set to be not collapsible?

Also, this helps alleviate the problem of too many tokens stopping the token browser from loading, though ultimately #1334456: Enable ajax on-demand loading of sub-trees in the Token help will be the best solution there.

Yes, but I believe there's no harm in committing this in the interim.

Definitely agree this should use the new dialog code, but this looked really strange with the link *inside* a collapsed fieldset, so I removed the fieldset. Please review.

Way better, please please commit!
Sites with a lot of tokens are just a pain in the ... to use when all the stuff is rendered at once.

Patch looks good. I'd say it's good to commit. As an aside, if you had memory issues with token tree's before, using the dialog approach may only delay the issue (as is the case for me with entity_token enabled and having LOTS of fields and entityreference's). I still like changing to the dialog approach.

As an aside, if you had memory issues with token tree's before, using the dialog approach may only delay the issue (as is the case for me with entity_token enabled and having LOTS of fields and entityreference's).

This approach still helps with overall memory consumption though, since without the dialog you're loading (at least) 3 full sets of tokens on one page, in addition to the form. In the dialog, you're loading only one set of tokens at a time and nothing else.

Patch looks good to me too. :)

Committed #6 to 7.x-1.x.