Change theme

When I try to checkout the code its asking for your password.

1. The proper Git checkout is: git clone --recursive --branch master http://git.drupal.org/sandbox/jotapato/1678168.git change_theme
2. Your working out of the master branch, you need to create a version specific branch, 7.x-1.x
3. Make sure to fix the issues outlined here: http://ventral.org/pareview/httpgitdrupalorgsandboxjotapato1678168git

In changetheme_perm() i see: 'administer change theme' as a name for a permission
When i look in the _hook_menu() i see a menu item for the admin page, calling: 'administer switch' to test access permissions.
(You won't notice it not working when you are logged in as the user 1 account obviously.)

I don't see an uninstaller to remove the variables set by this module. (not that big of a deal, but still, i always add it, to keep the variables table in a proper state.) (unused variables just take up space, not that much, but still)

The name for the variables starts with: 'changetheme_' and that's a good idea, makes it easier to remove only the variables set by this module.

And then coding style issues: try out the coder module, it has a release candidate available for Drupal 6, see:
http://drupal.org/node/1226024

"Coder found 1 projects, 3 files, 27 normal warnings, 37 minor warnings"

There are a lot of these reported by the coder module: "Line x: There should be no trailing spaces"
And "Line x: Control statements should have one space between the control keyword and opening parenthesis"
And "Line x: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms"
And "Line x: use a space between the closing parenthesis and the open bracket"

And the my_module.install also needs a @file declaration.

But it does indeed work, nice. When editing a group, you can select a theme to be used. (from a predefined list, configured via the change theme admin page on the og config page.)

And if i may: the name of this module, og (switch) theme (per group) or something would possibly fit more, also because the (already existing) 'switch theme' ( http://drupal.org/project/switchtheme ) module switches by browser version, but that's something for yourself to think some more about. (switch og theme, og theme switch, og theme select?, ...)

ps. the correct command to clone your repo is:
git clone http://git.drupal.org/sandbox/jotapato/1678168.git change_theme

Issues are not fixed yet: http://ventral.org/pareview/httpgitdrupalorgsandboxjotapato1678168git
Please, fix them.

Also, create a version branch (using official nomenclature, i.e. 6.x-1.x) and work on it.
After that remove master branch.

I have not yet installed the module itself but I already have a question. Could you explain us why this module is unique? May we not achieve the same results by using Context? Do you have any use cases where your method would be better that the Context module.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

How does this module play with http://drupal.org/project/themekey?

There are several modules for changing themes. Themekey is a popular example. If we are using one of those modules and we add your module, what is the result? Do they work together? Which takes precedence?

Issues are not fixed yet: http://ventral.org/pareview/httpgitdrupalorgsandboxjotapato1678168git
Please, fix them.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.