Description, Rationale

Monster Menus Panels Bridge allows a Monster Menus "page" to be panelized (via the Panels Module) similar to panelized nodes. Since Monster Menus uses an entirely different structure for its pages, it makes Panels integration impossible out of the box. My module bridges the gap between those "pages" and the Panels module allowing a user to panelize a Monster Menus page simply by checking the 'Create Panel' flag in the desired page's settings. All of the panelized pages respect the already-in-place permission settings for that page.

Project Info

Drupal version: 7.x
Project page: http://drupal.org/sandbox/nackersa/1780634
Git repository: http://git.drupal.org/sandbox/nackersa/1780634.git
Pareview report: http://ventral.org/pareview/httpgitdrupalorgsandboxnackersa1780634git

Author's Drupal Work

Accepted issues with patches:

Pending issues with patches:

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

Welcome,

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

nackersa’s picture

nackersa commented

@klausi, Thank you for your prompt response!

I do most of my module development while at work. They encourage us to contribute our modules back to Drupal and support them (we use these in production), but since I am on the clock, I am unable to review other modules on their time. So, I am okay with waiting until someone gets a chance to review this module under the normal project review process.

Again, thank you for your time!

chipway’s picture

chipway commented

@nackersa,

Just a quick review:

http://ventral.org/pareview/httpgitdrupalorgsandboxnackersa1780634git is OK.

But your Git repository should be http://git.drupal.org/sandbox/nackersa/1780634.git
instead of: http://drupalcode.org/sandbox/nackersa/1780634.git

Module folder name is unconsistant : it should be "mm_panels" : instead of "monster_menus_panels_bridge"

I don't understand why you have 2 functions to build your table in .install: You can all your function mm_panels_schema_1() inside of your function mm_panels_schema(). You can even build several tables trough keys of $schema array.

Why do you have this in .install?
function mm_panels_install() {
db_query("UPDATE {system} SET weight = 11 WHERE name = 'mm_panels_page'");
}

It looks like setting a heigher weigh for a module, but I didn' find any module of that name "mm_panels_page".

paravibe’s picture

paravibe commented

Add full git link. Like that git clone --branch 7.x-1.x http://git.drupal.org/sandbox/nackersa/1780634.git monster_menus_panels_bridge

Manual review:
mm_panels.module: line 49, instead of this $path = explode('/', $_GET['q']) use this $path = explode('/', current_path()). Because when we have a multisite current_path() return the right path. See current_path.
line 340, its bad to write HTML in .module file. Maybe you should use some template for this. See hook_theme.

paravibe’s picture

paravibe commented
Issue summary: View changes

updated accepted and pending patches

nackersa’s picture

nackersa commented

@chipway-drupal:
I have renamed all the module files to "monster_menus_panels_bridge" to match the module folder name. I have also removed the mm_panels_schema_1() function and merged its contents with hook_schema(). The reference to "mm_panels_page" in hook_install was a typo and should be "monster_menus_panels_bridge".

@drupalrv:
I have changed all references to $_GET['q'] to current_path(). I have also updated hook_process_panels_add_content_modal() to use theme('panels_add_content_link').

Thank you both for your time and feedback!

nackersa’s picture

nackersa commented
Priority: Normal » Critical

According to the Application Review Times section of the Review process for Full Project Applications: What to Expect page, a project application's priority level may be adjusted as follows:

  • Normal: All applications must begin with a normal priority. Applications with elevated priorities should be returned to normal priority once a reviewer has continued the application review.
  • Major: Applications with a status of needs review that have been awaiting response from a reviewer for 2+ weeks.
  • Critical: Applications with a status of needs review that have been awaiting response from a reviewer for 4+ weeks.

With that said, I am bumping up the priority level from "normal" to "critical".

Thanks to everyone for their time!

tanzeel’s picture

tanzeel commented

In readme.txt there is misleading information:
- Navigate to 'admin/build/modules' should be Navigate to 'admin/modules'

  • In some files module name "mm_panels" has been used and in others "Monster Menus Panels Bridge" has been used. Name should be consistent. (see install file)
  • No need to use return statement in hook_menu_alter(), hook_preprocess_page()
  • In hook_install user database layer to pass arguments to db_query instead of using direct values

Keep up good work.

likebtn’s picture

likebtn commented

Consider breaking lines in README.txt and monster_menus_panels_bridge.module up to 80 symbols.

kfritsche’s picture

kfritsche
Primary language German
Location 🇩🇪🇪🇺
commented
Status: Needs review » Needs work

Manual review:

monster_menus_panels_bridge.module:
- Idea: Maybe add the current access callback function name to the access arguments, before changing it. At the end of your function call the old access callback.
- Line 159: Never used variable $prefix.

Everything else seems good to me.

PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

PA robot commented
Issue summary: View changes

updated git link