Problem/Motivation

Fields like Date have a more complicated field property definition. In the case of Date, the field switches data structure based on whether or not it can have a to date (from a flat date to a struct). To properly reflect this in the mapping UI, we need to place the microdata flag dynamically in date_entity_metadata_property_info_alter, based on the field settings.

Since not all of the hook_field_info attributes get replicated into the Entity Property API, there are two places we need to check for the microdata flag.

Proposed resolution

Make sure that the microdata flag is replicated from field_info to the field's property settings. Refactor code to check flag using property API rather than field_info array.

API changes

None.

Comments

Anonymous’s picture

Anonymous’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

seandunaway’s picture

Status: Closed (fixed) » Needs work

This commit breaks the admin form at admin/services/microdata

Undefined notice for every attached field:

Notice: Undefined index: comment_body in theme_microdata_mapping_admin() (line 361 of /Users/-/Sites/-/sites/all/modules/microdata/microdata.admin.inc). =>
Anonymous’s picture

Ah, so it does. Thanks for the report.

daemonchrist’s picture

daemonchrist’s picture

Status: Needs work » Closed (fixed)

Re-closing, as the orginal issue was fixed long ago.