Testbot helper issue for 'formatters as plugins'

None of this is critical, but just thoughts upon reviewing the patch.

+++ b/core/modules/field/field.api.phpundefined
@@ -703,84 +709,11 @@ function hook_field_is_empty($item, $field) {
  * @param $info
- *   Array of informations on widget types exposed by hook_field_widget_info()
- *   implementations.
+ *   Array of informations on existing widget types, as collected by the

Since this description is changed, can we add type hinting here?

+++ b/core/modules/field/field.attach.incundefined
@@ -108,6 +108,234 @@ const FIELD_STORAGE_INSERT = 'insert';
+  // contain data for a single field for each name, even if that field
+  // is deleted, so we reference field data via the $entity->$field_name

Possibly needs to be rewrapped for 80 chars.

+++ b/core/modules/field/field.attach.incundefined
@@ -432,6 +660,37 @@ function _field_invoke_get_instances($entity_type, $bundle, $options) {
+ * @param mixed $display
+ *   @todo

Any explanation before patch is applied?

+++ b/core/modules/field/field.info.incundefined
@@ -496,27 +366,22 @@ function field_info_field_types($field_type = NULL) {
  * @param $widget_type
  *   (optional) A widget type name. If omitted, all widget types will be
  *   returned.
  *
  * @return
- *   Either a single widget type description, as provided by
- *   hook_field_widget_info(), or an array of all existing widget types, keyed
- *   by widget type name.
+ *   Either a single widget type description, as provided by class annotations
+ *   or an array of all existing widget types, keyed by widget type name.

Can we add type hinting here?

+++ b/core/modules/field/lib/Drupal/field/FieldInstance.phpundefined
@@ -0,0 +1,222 @@
+
+  public $definition;
+
+  /**
+   * @var Drupal\field\Plugin\Type\Widget\WidgetInterface
+   */
+  protected $widget;
+
+  /**
+   * @var array
+   */
+  protected $formatters;

No descriptive text for each of these members?

The actual patch is in.

Added parent issue #