Missing $language in update_mail() [#1785966]

webchick reported this at http://drupal.org/node/1784796#comment-6481774

Notice: Use of undefined constant langcode - assumed 'langcode' in _update_message_text() (line 604 of core/modules/update/update.module).
Notice: Undefined variable: language in update_mail() (line 518 of core/modules/update/update.module).

Looking at the code, indeed, update_mail() still tries to use $message['language'] which is of course not passed anymore.

Comment	File	Size	Author
#1	language-object-update.patch	701 bytes	gábor hojtsy

Comments

Comment #1

gábor hojtsy

he/him

Hungarian

Hungary

commented 17 September 2012 at 13:14

Status:	Active	» Needs review
Issue tags:		+Needs tests

Status	File	Size
new	language-object-update.patch	701 bytes

I was looking at the api.drupal.org version of the code, which seems to be outdated. There does not seem to be any code in Drupal anymore referencing $message['language'], so that is not the problem :) However as the error message says the variable $language is not present, which was lost in the conversion.

I'm not sure it is trivial to have tests for this.... Do we have any tests for the mail system that inspects mails sent (which would have triggered this error)?