OG User Roles redirects in wrong instances

there remains (so I think) one problem: it redirectsall content add pages, not just the ones that are group related.

This is not true. It only redirects create content links from a Group Home page. When you look at the code, this is what you should see:

    // If this is a group node/add, re-direct to ognodeadd
    if (arg(0) == 'node' && arg(1) == 'add' && isset($_REQUEST['gids'])) {

Thanks. I see your issue more clearly. May I ask: Why does the /node/add link include the query "gids[]" if it is not a group link and specifically omitted by OG?

Oops. You're right. Looks like I didn't notice this code:

    // Modification as per: http://drupal.org/node/174959
    // If this is a non-group node/add, but og_last session cookie is set
    // then re-direct to ognodeadd
    if (arg(0) == 'node' && arg(1) == 'add' && $_SESSION['og_last'] && (!is_null(arg(2))) ) {

This could do it. However, before I try to fix this, shouldn't the test line be:

      if ($og_audience_required && (!in_array($type, $og_omitted)) ) {

as opposed to:

if ($og_audience_required && in_array($type, $og_omitted) { // I'm assuming you already have

Troubleshooting isn't always the easiest thing. Thanks for your patience.

Then try this patch against a clearn version of the 5.x-2.4 release. Let me know if it works for you.

Here's the actual patch.

The patch certainly fixed the issue - I haven't tested out the general module functionality to see if it broke anything, however - will post any issues if they come up.

I need some specifics. I have to try and re-create the problem. What node types are omitted that still get re-directed by OGR. Is the audience required check valid for the group?

Tell me what I need to know to consistently recreate the problem.

I'm getting this same issue. I have a block on the left panel of all pages that has a link to create a new group (so it's '/node/add/basic-group'), but when in a group context this gets redirected to ognodeadd. It seems like the og_user_roles code is a bit overzealous with redirecting when $_SESSION['og_last'] is set.

Applying the changes in that patch seems to have cleared everything up.

Same thing for the redirecting to oguseredit, which was also giving me problems.

The types that redirect incorrectly are, now that I think about it, all completely cck-based. Module or system defined content types such as "blog" or "story" do not redirect incorrectly. All of these should be in the og_omitted array. The "Audience Required" checkbox is checked.

Great. This is a good start. Now, give me an exact example of a cck-based type that is being re-directed incorrectly. I still don't know what you mean, or why this is happening, so I'd like to re-create the same exact environment to see what needs to be done.

Thanks!

I ran some tests.

First off, from the way I see it, if you have a node type "Test", and it is omitted from group content, then no group role should have the "Create test" permission. And, if no group role has this permission, then it won't appear on the group menu. However, if you give site-side permission to "create test" nodes to a user, then it will appear in his main menu.

One way to cancel group context is to NOT expand your "Create content" links in the Main Menu. By doing this, you will no longer have a link to "Create test" under any circumstances while a user is within a group. This would solve your problem right away.

I ran this test:

1. Create content type named "Test Content Type" (type = "test").
2. Omitted it in group settings.
3. Expanded the "Create content" menu so that link to create "Test Content Type" will appear in main menu.
4. Went into group that previously had "Create Test Content Type" link. Link no longer appears.
5. Clicked on "Test Content Type" under "Create content" in main menu. No re-direction.
6. Changed name to "Test Type". Repeated test. No re-direction.

This appears to be the desired behaviour.

It sounds like from everything you've reported, the patch is working even in your case -- with the exception of when you alter the name of a content type. However, I've not been able to duplicate that particular problem.

My suggestions at this point:

1. Unexpand the "Create content" link on the main menu.
2. If possible, do not give sitewide permission "create test" to role(s) that group members will have.

I'm sorry, neither of your suggestions is possible for me to comply with, as 1) I am using a delicate combination of access control modules, and 2) I am using nice_menus, not drupal's default menus.

Then, I'm not sure I can help you because with the default Drupal main menu expanded, when I click on the "Group" submenu item under "Create content" from within a group, I am NOT re-directed. This is as it should be.

I should have made my problems more clear. Firstly, the content type redirects in the case of group type nodes, which it should not do, because group type nodes are not in og_omittted array.

Since OGR supports creating subgroups, it is not possible to eliminate a content type simply because it is a group content type.

Secondly, the content type redirects in the case of a machine-readable content name with dashes in it and a human-readable name with spaces (sorry, can't be more specific than that).

This does sound pretty weird. I don't see anything in OGR code that would cause this on it's own. What I would do here is simply make a note in the OGR documentation that this sort of behaviour has been reported, so try to avoid dashes in your machine-readable content name. I can not reproduce the problem with spaces in the human-readable name.

If someone can produce some code that they think would solve this issue, I'm certainly happy to take a look at it.

This was an issue for us for dashed content types as well as ognodeadd overwriting a url scheme we are using to handle petition signatures that link back to a parent node(http://drupal.org/node/158172#comment-1026155). The code below seems to fix both problems. I am not sure why omitted was not adequate, but in our case it was not.

$og_permitted = og_is_group_post_type ($type);
if ($og_permitted && $og_audience_required && (!in_array($type, $og_omitted)) ) {

subscribing

@icstars:

So, you're saying this:

      if ($og_audience_required && (!in_array($type, $og_omitted)) ) {

should be replaced with this:

  $og_permitted = og_is_group_post_type ($type);
  if ($og_permitted && $og_audience_required && (!in_array($type, $og_omitted)) ) {

$og_permitted patch committed to 5.x and 6.x dev releases.