These patches require that the images be moved to an images directory as per all previous themes. The only images outside of the directory should be screenshot and logo.

CommentFileSizeAuthor
#14 sff_fix_urls.patch5.42 KBTDobes
#11 style_2.patch9.39 KBcarlmcdade
#5 style_1.patch9.69 KBcarlmcdade
#4 style_0.patch9.43 KBcarlmcdade
#3 page_0.patch754 bytescarlmcdade
#2 nav.patch2.05 KBcarlmcdade
#1 modules.patch5.28 KBcarlmcdade
layout.patch1.2 KBcarlmcdade

Comments

carlmcdade’s picture

carlmcdade commented
StatusFileSize
new modules.patch5.28 KB

These patches require that the images be moved to an images directory as per all previous themes. The only images outside of the directory should be screenshot and logo.

carlmcdade’s picture

carlmcdade commented
StatusFileSize
new nav.patch2.05 KB

These patches require that the images be moved to an images directory as per all previous themes. The only images outside of the directory should be screenshot and logo.

carlmcdade’s picture

carlmcdade commented
StatusFileSize
new page_0.patch754 bytes

These patches require that the images be moved to an images directory as per all previous themes. The only images outside of the directory should be screenshot and logo.

carlmcdade’s picture

carlmcdade commented
StatusFileSize
new style_0.patch9.43 KB

These patches require that the images be moved to an images directory as per all previous themes. The only images outside of the directory should be screenshot and logo.

carlmcdade’s picture

carlmcdade commented
StatusFileSize
new style_1.patch9.69 KB

I noticed that the header was taller than the original as I set it that way to test. When I readjusted it I saw the logo was 4 px too tall and the site title text was off. This patch fixes those slight adjustments. After this I could not find anything else wrong.

carlmcdade’s picture

carlmcdade commented

the slightly shorter logo

TDobes’s picture

TDobes commented

Please do not apply either of the patches for style.css as-is. For some reason, it renames the "picture" classes back to "avatar", which is horribly wrong for 4.5 and beyond. These changes need to be edited out. In 4.5, avatars were renamed to "user pictures". See the "upgrading themes to 4.5" page from the handbook.

carlmcdade’s picture

carlmcdade commented

Can you give more detail on the problem? The names of CSS classes should not be factor in the rendering of PHP. I could not find anything specifically pointing to the names of the classes needing to be changed only the template variables and functions.

TDobes’s picture

TDobes commented

Yes. Here are the exact lines from the patch to style.css:

-div.picture { 
+div.avatar { 
   float: right;
   border: 1px solid #ddd;
 }
-.picture {
+.avatar {
   margin: 0 0 10px 0;
 }
-.picture-left {
+.avatar-left {
   float: left;
   margin-right: 10px;
 }
-.picture-right {
+.avatar-right {
   float: right;
   margin-left: 10px;
 }

You'll note that the patch removes the picture classes and replaces them with avatar classes. This will effectively break the styling of user pictures on Drupal 4.5 or later.

TDobes’s picture

TDobes commented

Also, the picture div is generated by the function theme_user_picture in user.module. Here's the line of code in question:
return "<div class=\"picture\">$picture</div>";

carlmcdade’s picture

carlmcdade commented
StatusFileSize
new style_2.patch9.39 KB

Got it. That is weird that it does this. Diff is merging backwards on just those lines. I did a search and replace on the older style.css so that diff does not have to deal with it.

kbahey’s picture

kbahey commented
Title: Patches for page header corners and for moving images to a directory » Images should be in their own "images" directory
Assigned: Unassigned » kbahey

Carl, thanks for the idea. I did not use your patches, but did the same thing you wanted done. It makes a lot of sense.

Moved all images to their own directory.

I did not commit the resizing of the header and the new logo. I need more detail on what that does. Perhaps a before and after screen shot to explain what and why, and a separate patch/issue is in order.

chrismessina’s picture

chrismessina commented

The lack of images subdirectory is simply a leftover from this being a 4.4 theme.

Also, I wouldn't change the header size. While I should document the logo creation process, changing the CSS wily-nilly could be pretty dangerous.

The most important things to do are to simply convert all the styles to be 4.5 compatible. Innovation can happen once that's done.

TDobes’s picture

TDobes commented
Title: Images should be in their own "images" directory » Images broken due to misplaced double-quotes
Category: task » bug
StatusFileSize
new sff_fix_urls.patch5.42 KB

As a side-effect of the move of images to a subdirectory, a lot of images are now broken due to misplaced quotes... for example, background: url(images/"bg_header_top_left.gif") no-repeat;

The attached patch simply removes these quotes, fixing the problem.

Anonymous’s picture

(not verified) commented
Assigned: kbahey » Unassigned

I see this has been fixed in style.css, but the problem still exists in modules.css and nav.css.

kbahey’s picture

kbahey commented
Component: Graphics » Stylesheets
Assigned: Unassigned » kbahey

Fixed in CVS HEAD.

Anonymous’s picture

(not verified) commented