button background images are always loaded from markitup/sets/default/images [#1786732]

The images used for background images in markItUp are always pathed
/sets/default/images/.png. It would be useful for modules to specify other image names or directories in order to seperate module-specific buttons from the default set. Additionally, this can be useful when integrating other full sets into wysiwyg without copying the images to default/iamges.

Comment	File	Size	Author
#6	wysiwyg-arbitrary_image_paths_markitup-1786732-6.patch	1.2 KB	cboyden
#3	wysiwyg-arbitrary_image_paths_markitup-1786732-3.patch	1.23 KB	populist
#1	wysiwyg-arbitrary_image_paths_markitup-1786732-0.patch	1.04 KB	kienan

Comments

Comment #1

kienan commented 17 September 2012 at 14:29

Status:

Active

» Needs review

Status	File	Size
new	wysiwyg-arbitrary_image_paths_markitup-1786732-0.patch	1.04 KB

Potential patch.

In hook_editor_settings_alter(), the following two fields can be added to the button's array: "imageDir" which specifies the base image dir. Default remains the same as before, and "imageFile" which can be used the specify the file name. The default for "imageFile" is the buttonname.png.

Comment #2

populist commented 8 November 2012 at 20:36

I would also like to add it would be helpful to have a NULL option (which perhaps this would allow). There is a use case I have seen where you want to add button separators (which Markitup! allows and provides a classname for) but WYSIWYG.module's JS will try to load an image anyway.

Comment #3

populist commented 8 November 2012 at 20:48

Status	File	Size
new	wysiwyg-arbitrary_image_paths_markitup-1786732-3.patch	1.23 KB

Here is a re-roll of the patch in #1 which adds a check for the special class "markItUpSeparator". This is used in Markitup! core to denote a separator and won't need a button.