Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is a regression from #1661066: Add a helper for getting the controller.
We should probably unprotected $controller->entityType and use that to fetch the info.
Comment | File | Size | Author |
---|---|---|---|
#17 | ief_unserializable_string.png | 48.44 KB | holdmann |
#4 | ief-1786814-4.patch | 1.02 KB | pjcdawkins |
#2 | 1786814.1.patch | 604 bytes | rogical |
Comments
Comment #1
rogical CreditAttribution: rogical commentedNotice: Undefined variable: entity_info in inline_entity_form_field_widget_settings_form() (line 233 of /opt/production/pjkaixin/sites/all/modules/inline_entity_form/inline_entity_form.module).
same issue
Comment #2
rogical CreditAttribution: rogical commentedComment #3
angheloko CreditAttribution: angheloko commentedAlso encountering same error. Patch in #2 works for me.
Thanks.
Comment #4
pjcdawkins CreditAttribution: pjcdawkins commentedThe patch in #2 would stop the notice, but it shows the wrong label (the field instance label, rather than the entity type label). Here's a patch (attached) that's more in the spirit of what the code is trying to achieve here, and it's what the OP suggests.
Comment #5
star-szr#4 tested and working on the latest 7.x-1.x-dev.
To be more specific, this notice comes up when editing a field with an inline entity form widget. i.e. admin/structure/types/manage/product_display/fields/field_product_variations
Comment #6
theo_ CreditAttribution: theo_ commentedWe need patch from #4 to be commited.
Comment #7
pjcdawkins CreditAttribution: pjcdawkins commentedBased on the last two comments I'm marking my own patch RTBC.
Comment #8
idflood CreditAttribution: idflood commentedPatch in #4 looks good and fixed the error for me,
Comment #9
dimitriseng CreditAttribution: dimitriseng commentedPatch #4 has fixed the error for me as well, thanks.
Comment #10
Zach Harkey CreditAttribution: Zach Harkey commentedPatch #4 has fixed the error for me as well, thanks.
Comment #11
yurg CreditAttribution: yurg commentedPatch #4 has fixed the error for me as well, thanks.
Comment #12
cedricvg CreditAttribution: cedricvg commentedI Got the same error when adding a entity reference field to a node, patch 4 fixes it for me.
Comment #13
malberts CreditAttribution: malberts commentedAny update on whether patch #4 could get committed? It works and seems simple enough.
Comment #14
manox CreditAttribution: manox commentedPatch #4 doesn't work for me, get a white page aber patching. Any other solution yet?
Comment #15
Albert Volkman CreditAttribution: Albert Volkman commented@manox please post your apache error log when you get the white page.
Comment #16
Ollie222 CreditAttribution: Ollie222 commentedPatch #4 has fixed the error for me as well, thanks.
Comment #17
holdmann CreditAttribution: holdmann commentedHi!
this patches fix just visual part of problem. Reason of this notice - unserializable json string in field_config_instance.
Thying to unserialize string returns nothing ((bool) false):
Any suggestion?
Comment #18
pjcdawkins CreditAttribution: pjcdawkins commented#17: that is not related to this thread, whatever it is. The patch in #4 is here to fix a straightforward problem, that
$entity_info
is not defined. It just trivially implements what the OP describes as the solution. It's received 7 positive tests/reviews above. I'm not sure why it hasn't been committed yet.Comment #19
malberts CreditAttribution: malberts commentedAny update on this?
I used #4 again on another completely different site (a month later).
Comment #20
pjcdawkins CreditAttribution: pjcdawkins commentedIt seems to be on its way.
http://twitter.com/CommerceGuys/status/268821893639966720
Comment #21
bojanz CreditAttribution: bojanz commentedCommitted a slightly different fix:
http://drupalcode.org/project/inline_entity_form.git/commitdiff/36af6a8?...
Thank you for your patience. Kickstart contains many modules and I cycle through them.