Convert taxonomy module formatters to Plugin system

I start working on this, as of NOW

forgot status change

Removed trailing spaces, sorry

Found a comment that was not correct.

Looks good. I found one minor issue.

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/field/formatter/RSSCategoryFormatter.phpundefined
@@ -0,0 +1,48 @@
+          'domain' => $item['tid'] != 'autocreate' ? url('taxonomy/term/' . $item['tid'], array('absolute' => TRUE)) : '',

Lets use entity uri $item['taxonomy_term']->uri() for consistency.

Removed the taxonomy_field_formatter_* hooks and switched to $item['taxonomy_term']->uri() in RSSCategoryFormatter.

great webflo, thx a lot!

Nothing new, just it works.
The patch #10 is not applicable to the latest 8.x.

Bumping, this is now a blocker for #1950632: Create a FieldDefinitionInterface and use it for formatters and widgets.

Anyone up for reviving this ?

Crap, completely forgot about this one

Here is the re-roll lets see how much it fails.

I even think it might be green - or at least really close. 2 remarks regarding documentation we need to fix

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/field/formatter/LinkFormatter.phpundefined
@@ -0,0 +1,60 @@
+ * Definition of Drupal\taxonomy\Plugin\field\formatter\LinkFormatter.

Should be Contains \Drupal (apparently with leading forward slash now right ?)

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/field/formatter/LinkFormatter.phpundefined
@@ -0,0 +1,60 @@
+   * Implements Drupal\field\Plugin\Type\Formatter\FormatterInterface::viewElements().

Should all be {@inheritdoc}

oh and thank you also for the re-roll! :)

i think thats why this was forgotten
#1847596: Remove Taxonomy term reference field in favor of Entity reference which is postponed on #1818560: Convert taxonomy entities to the new Entity Field API
maybe we should postpone or duplicate it

As far as I can see, #1818560: Convert taxonomy entities to the new Entity Field API wouldn't conflict that much (maybe not at all), so I'd rather go ahead with this one because I think the other one is going to be a while for that goes in I'm afraid.

Agreed with @swentel. Most of the job is done already, and getting to a point where there are no legacy widgets and formatters will be precious to unblock other work.

the other one is going to be a while for that goes in I'm afraid

agreed..
tagging

Changed the documentation, and tests should be fixed.

#24 looks great. Just some nits:

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/field/formatter/LinkFormatter.php
@@ -0,0 +1,60 @@
+    // Terms whose tid is 'autocreate' do not exist
+    // yet and $item['taxonomy_term'] is not set. Theme such terms as
+    // just their name.

The code below this uses $item['entity'] instead of $item['taxonomy_term'], so let's update the comment accordingly. Also, I think the line breaks can be adjusted so that this fits on two lines.

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/field/formatter/PlainFormatter.php
@@ -0,0 +1,49 @@
+    // Terms whose tid is 'autocreate' do not exist
+    // yet and $item['taxonomy_term'] is not set. Theme such terms as
+    // just their name.

Ditto

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/field/formatter/RSSCategoryFormatter.php
@@ -0,0 +1,59 @@
+    // Terms whose tid is 'autocreate' do not exist
+    // yet and $item['taxonomy_term'] is not set. Theme such terms as
+    // just their name.

And once more.

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/field/formatter/TaxonomyFormatterBase.php
@@ -0,0 +1,75 @@
+  /**
+   * {@inheritdoc}
+   */
+  public function viewElements(EntityInterface $entity, $langcode, array $items) {}

Is there a reason for an empty implementation of this on the base class? If not, let's remove it and make the class abstract.

Two nitpicks, after that it's good.

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/field/formatter/TaxonomyFormatterBase.phpundefined
@@ -0,0 +1,70 @@
+      // Iterate through the fieldable entities again to attach the loaded term data.

80 chars limit

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/field/formatter/TaxonomyFormatterBase.phpundefined
@@ -0,0 +1,70 @@
+          // Check whether the taxonomy term field instance value could be loaded.

same here

#30: taxonomy-formatters-plugins-1787248-30.patch queued for re-testing.

#26 and #29 addressed, so RTBC. Thanks!

Committed and pushed to 8.x. Thanks!