New groups are unpublished by default until approved. Let's provide a simple view where administrative users can publish these or mark them as rejected (probably a simple cck field).

We could add a "group moderator" role, or make this view accessible to administrative users with a different role.

CommentFileSizeAuthor
#9 1787306_groups_moderation_view.patch17.37 KBjaperry

Comments

geoffreyr’s picture

geoffreyr commented

Regarding the "group moderator" role, is this role defined on OG or Drupal itself? Based on the description I'm guessing it's the latter. This role is something I can roll into our implementation.

I'm asking because I'm wondering whether there needs to be an OG group moderator role that is distinct from the OG group administrator role. In our workflow, the group moderator has the rights to approve/add/remove members and administer the group, but only the group administrator can customise the group's permissions and update the group.

ezra-g’s picture

ezra-g commented

After further thought it seems likely that we'd want a single "Content moderator" role that can be re-used for having full spam moderation permissions.

Sine this will likely be re-used elsewhere the role should be defined in a re-usable module. I propose either a Commons content moderation module or a new Commons_misc module to contain this and other components that are likely to be re-used across various Commons features.

geoffreyr’s picture

geoffreyr commented

Containing these permissions in a Content Moderation module is sort of along the lines of what I was thinking, but I'm not sure if that should extend to the OG Permissions settings as well. Nevertheless it'd be good to make this reusable, especially for the functionality you're discussing above.

Perhaps I could whip up a sandbox with an example?

geoffreyr’s picture

geoffreyr commented

Here's a link to my sandbox for a first pass at this feature:
http://drupal.org/sandbox/geoffreyr/1809332

ezra-g’s picture

ezra-g commented
Project: Commons Groups » Drupal Commons
Component: Code » Groups

Moving this to the main Drupal Commons issue queue per #1812492: Consider using central issue queue for Commons projects.

ezra-g’s picture

ezra-g commented
Priority: Normal » Major
Status: Active » Needs review

Thanks, @geoffreyr!

Marking as "needs review".

ezra-g’s picture

ezra-g commented
Issue tags: +commons-7.x-3.0-beta1

Tagging for beta1.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Assigned: Unassigned » kscheirer
Status: Needs review » Needs work
Issue tags: -commons-7.x-3.0-beta1

I'm going to create a default view thats available as a tab on /admin/content, and shows a list of unpublished groups. Do you need a block as well (useful for D7 dashboard)?

japerry’s picture

japerry
Location KOMK
commented
Status: Needs work » Needs review
StatusFileSize
new 1787306_groups_moderation_view.patch17.37 KB

Here is the groups view, ezra wanna review the patch before I commit?

ezra-g’s picture

ezra-g commented
Assigned: kscheirer » japerry
Status: Needs review » Needs work

japerry is working on a few tweaks to this patch following some conversation in IRC. Marking as "needs work" and assigning over to him.

japerry’s picture

japerry
Location KOMK
commented
Status: Needs work » Fixed

Fixed the issues from review and committed! Left the buttons both green, and we can revisit later if the UI demands different colors or sizes.

You can see the admin view at admin/content/groups

5a7ba4b09450d3818443753a6b27c1528a7f0acc

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.