Hi
recently a module was contributed to improve statistics collection in the accesslog, Better Statistics.
This module extends the accesslog table, adding additional fields whose content can be filled in by any module, via an API.
See:
#1775380: Integration with Browscap module?
#1779204: Create a statistics API
http://www.asmallwebfirm.net/blogs/2012/09/introducing-better-statistics...
While I'd love to see Browscap joining Better Statistics through its API, there is also a need for eyes to review Better Statistics itself before releasing, so if anyone can help, please do.
Also, it looks like in D8 the accesslog will be dropped from core
#1446956: Remove the accesslog from statistics
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | browscap-better_statistics_integration-1787488-1.patch | 18.87 KB | mondrake |
Comments
Comment #1
mondrakeThe patch attached provides Browscap integration to Better Statistics 7.x-1.1
There are no dependencies. It only adds a browscap.statistics.inc file to enable Browscap to feed the Statistics API, and implements in the main module file the hook_statistics_api().
Comment #2
devin carlson commentedHey mondrake,
Good timing with a proposal for statistics integration. I'm actually planning to remove all statistics functionality from Browscap in the next version of the module; turning Browscap into an API-only module.
The current statistics functionality included with Browscap is very basic and is missing a large number of important and helpful features, plus there hasn't been much indication that it is even used.
With that said, I'm not going to include any integration between Browscap and other modules but I'd definitely give a +1 to creating a module that provides integration between Browscap and Better Statistics. I might even be able to give it a review to help get it through the project issue queue or provide some guidance if there are any issues.
Comment #3
mondrakeHi Devin and thanks for feedback.
I am re-opening for discussion if you do not mind.
I do not think it is a problem to package a module for this, it may also give the opportunity to include a couple of canned views to replace current Browscap stat reports.
What I am skeptical about is to make a standalone project of its own on d.o. - one more issue queue, possible future compatibility issues, etc.
Would it make sens to include such a module (I have a shortname: 'browscap_statistics') as a submodule either in Browscap package or Better Statistics package?
I'd love to get your (and iamEAP) thoughts on this.
Is new version going to introduce API changes besides severing the statistics part?
Comment #4
iamEAP commentedOn holiday, sorry for the late entry to the discussion.
I would definitely prefer to keep submodules out of the main Better Stats repo, particularly those integrating other modules.
A sub-module of Browscap would be more appropriate, but I feel like there are hardly any benefits of doing so over including it as part of the main module. There'd be no performance overhead and the maintenance overhead would be minimal either way.
I'm also not sure a completely separate integration module would be very appropriate either, given mondrake's points above about compatibility worries in addition to the relatively few benefits of doing so.
Comment #5
iamEAP commentedWas looking for modules that implement the Stats API and remembered this thread.
Sounds like the best bet is to create a glue module. Perhaps just "Browscap Statistics."
I personally do not wish to maintain that. Mondrake, would you be willing?
Comment #6
mondrakeNot really... besides the general philosophical question (what's the purpose of developing APIs if then you have to develop a module to bridge two modules), I cannot really see this working without at least
#1868808: False/true not converted to 0/1 during browscap.ini import
#1852184: Browscap error parsing when trying to fetch browscap data
and possibly
#1788720: Allow to change the URLs to use for importing useragent information
checked in.
What I can do, if anyone is interested, is creating a sandbox with a fork of Browscap 7.x-2.x with the above applied + the integration piece for Better Statistics.
Comment #7
mondrakeNo activity on this project, I'll close this issue. Also, the BCP project upstream has been struggling recently. I am currently investigating alternative solutions like the Detector module and libraries.