Instead of seeing the quantity edit, amount and one time setup fee as set up for my subscription I instead just get:

$0.00
every undefined undefined

So its basically not pulling the subscription plan at all but pulls in the contact and billing form. How can I help to debug?

CommentFileSizeAuthor
#7 add_recurly_default_currency-1788522.patch1.35 KBquicksketch
#6 add_recurly_default_currency-1788522.patch1.26 KB7wonders
#4 add_recurly_default_currency.patch870 bytes7wonders

Comments

7wonders’s picture

7wonders commented

Seems its not adding a currency to the end of the url on the subscription page. So therefore its setting Currency USD by default and there doesnt seem to be a way to change that??

jeremymcminn’s picture

jeremymcminn commented

Had this same problem also, so changed my currency to USD - not ideal but will have to work for the time being.

7wonders’s picture

7wonders commented

A quickfix is to change line 111 recurlyjs.pages.inc from USD to the currency you want. Im looking into a proper fix now.

7wonders’s picture

7wonders commented
StatusFileSize
new add_recurly_default_currency.patch870 bytes

Here is a very simple fix in the meantime that adds a "recurly default currency" setting to the admin page. I think this was maybe the intention from the start as there is a few variable_get('recurly_default_currency', 'USD'); dotted around the place.

7wonders’s picture

7wonders commented
Status: Active » Needs review
7wonders’s picture

7wonders commented
StatusFileSize
new add_recurly_default_currency-1788522.patch1.26 KB

With the uninstall variable too!!

quicksketch’s picture

quicksketch
he/him
commented
StatusFileSize
new add_recurly_default_currency-1788522.patch1.35 KB

Thanks guys! For reference, you can also just tack the currency code at the end of your URLs to your subscription page. i.e. user/1/subscription/signup/[plan_name]/AUD. But I definitely agree that this needs to be configurable to set the site default. I added some extra description text and shortened up the presentation of the field. Committed this patch. Thanks!

quicksketch’s picture

quicksketch
he/him
commented

Seems its not adding a currency to the end of the url on the subscription page. So therefore its setting Currency USD by default and there doesnt seem to be a way to change that??

Oh, seems that you already knew that and tried to change it. I don't have access to a Gateway that supports multiple currencies, so I haven't been able to explicitly test the multiple currency support. Seems like we've got another bug that actually needs to be fixed rather than just adding this setting.

quicksketch’s picture

quicksketch
he/him
commented
Title: Recurly.js every undefined undefined » Recurly.js "every undefined undefined" message when using non-default currency
Status: Needs review » Needs work

I've committed the patch in #7, but we still have this problem if you want to use a different currency than the default.

quicksketch’s picture

quicksketch
he/him
commented
Issue summary: View changes
Status: Needs work » Closed (fixed)

Re-reading this issue I think I misunderstood. The problem was when:

1) You have a currency default in Recurly that is not USD.
2) You visit the signup page without a currency in the URL.

Now that you can change the default currency in the Drupal module to match Recurly, we no longer have this issue (I think). I still don't use Recurly for multiple currencies so I can't test this, but it sounds as though this problem has been resolved.