The upgrade path from Drupal 6 to Drupal 7 is broken in FillPDF. Several of the updates in Drupal 7 are unnecessary to run because they've already been run in Drupal 6.

To reproduce:
- Install Drupal 6.
- Install Fill PDF
- Point a fresh Drupal 7 installation at the D6 database.
- Install Fill PDF for Drupal 7.
- Try to run update.php.

You will get the following error:

Cannot add field <em class="placeholder">fillpdf_forms</em>.<em class="placeholder">destination_path</em>: field already exists.

If you were to fix that error, you'd find the same problem with several of the DB fields added in the 700x updates. All these fields already exist in the D6 version, since the two versions have identical DB schemas. Fortunately Drupal 7 has the nice db_field_exists() function, so all we need to do is wrap all the db_add_field() calls with a check first.

CommentFileSizeAuthor
#1 fillpdf_column_check-1788626-1.patch2.14 KBquicksketch

Comments

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Needs review
StatusFileSize
new fillpdf_column_check-1788626-1.patch2.14 KB

Patch.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented

Whoa, why did I never see this? Will review soon. I didn't even know Fill PDF *had* a 7.x upgrade path :P

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Status: Needs review » Fixed

Committed to 7.x-1.x. Attribution given. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.