The current exposed form has the feature to automatically provide a autosubmit class if wanted.
This could be made optional but this is still not fine for core.

CommentFileSizeAuthor
#2 views-1789270-2.patch2.52 KBdawehner

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: +CTools dependency

Whoops, guess we missed this one.

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new views-1789270-2.patch2.52 KB

Opened up an issue in ctools: #1790006: Add a autosubmit exposed form plugin

dawehner’s picture

dawehner
Primary language German
commented
Assigned: Unassigned » tim.plunkett

Maybe another review for you, tim?

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

Sure, deleting code is great, but I spent a lot of time trying to get CTools back to passing tests and its still missing one http://qa.drupal.org/pifr/test/274403

We should fix that before moving code there.

dawehner’s picture

dawehner
Primary language German
commented

To be honest this change is so simple ... well the chance to cause another rerole is pretty low. I will try to fix this test.

dawehner’s picture

dawehner
Primary language German
commented

Created an issue for that: #1794538: Fix jumpmenu tests

dawehner’s picture

dawehner
Primary language German
commented

We could move it now

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Fixed

Committed and pushed

Automatically closed -- issue fixed for 2 weeks with no activity.