Drupal services section (marketplace_services.feature, marketplace_categories.feature) [#1790084]

I took a look at these 3 files related to Marketplace:
http://drupalcode.org/project/doobie.git/blob/HEAD:/features/drupalorg/m...
http://drupalcode.org/project/doobie.git/blob/HEAD:/features/drupalorg/m...
http://drupalcode.org/project/doobie.git/blob/HEAD:/features/drupalorg/m...

I'm not sure if they all are valid, seems like they repeat each other a bit.

Small comments:
/features/drupalorg/marketplace.feature

Scenario: See a filtered list of service providers
25     Given I am at "/marketplace"
26     When I click "Consulting"
27     And I click "Government"
28     Then I should see the link "Achieve Internet"
29     And I should not see the link "2020Media"

Using specific company titles won't work since it's changing all the time.

features/drupalorg/marketplace2.feature

13   Scenario: See a paged list of service providers
14     Given I am on "/drupal-services"
15     When I follow "Marketplace"
16     Then I should see at least "10" records - probably needs "And I should see the following links..."
17     And I click on page "2"
18     And I should see at least "10" records
19     And I should see the following <links>
20     | links    |
21     | first    |
22     | next     |
23     | previous |
24     | last     |
25     And I should see at least "10" records  - this repeats line 18
26     When I click on page "last"
27     Then I should see at least "1" record - probably needs "And I should see links "first, previous" and not "last, next"

Some suggestions on what would be good to test for Drupal services section (sorry if it exists already somewhere):
- both Featured and All providers views exist (and check for sidebar text which is specific per section)
- sidebar links "Working with Drupal.." "Marketplace guidelines" etc. work
- anonymous users can't see "Add your listing" button (note: I just figure they can see it so we'll need to fix this first)
- authenticated users can see "Add your listing" and can create organization node
- if you open company page from Featured providers list - you should see "This organization is a Featured service provider" on top of the page
- if you open company page from All providers list - you should see "This organization is a Drupal service provider" on top of the page
- when user creates organization page - if he clicks "Request listing in the Drupal services section" and saves:

new issue is automatically created in webmasters queue
user should see "Regarding services listing communicate with webmasters using this issue" on top of the organization node (only node authors and admins can see that message)
clicking "this issue" should open webmasters issue with title "Review [companyname]"

- when user creates organization page - it should not be listed in Marketplace, we need to check that moderation fields have proper values:

Services listing: Do not list
Issue for review: empty
Training listing: Do not list
Training issue: empty
Hosting level: not listed for hosting

- #1706692: Marketplace node owners should not be able to edit certain fields
- if user enters organization node's title as "Current company" in his profile - this user should show up on the right side of the organizations page

Comments

Comment #0.0

tvn commented 20 September 2012 at 10:02

Issue summary:

View changes

err

Comment #1

pradeeprkara commented 3 October 2012 at 14:24

Version:		» 6.x-1.x-dev
Assigned:	Unassigned	» sachin2dhoni
Issue tags:		+sprint 11

assigning and tagging

Comment #2

sachin2dhoni commented 5 October 2012 at 15:23

Status:

Active

» Needs review

Updated to dev branch

Please check the commit log8d946f1

Also added @retest-after-next-build tag as the logins are not working.

Comment #3

eliza411 commented 6 October 2012 at 11:49

Status:

Needs review

» Needs work

Retest tags should go on the issue, not in the file. The tags field group is easy to miss: http://awesomescreenshot.com/0f3ib5321

I've removed the re-test tags and I've retested and this all seems to be working - including a failure at

  @anon
  Scenario: Following through featured providers post                      # features/drupalorg/marketplace_drupalservices.feature:22
    Given I am on "/drupal-services"                                       # FeatureContext::visit()
    And I follow "Featured providers"                                      # FeatureContext::clickLink()
    When I follow Featured providers title post                            # FeatureContext::iFollowFeaturedProvidersTitlePost()
      [curl] 28: Operation timed out after 30063 milliseconds with 0 out of -1 b

The pages are really timing out, so I've marked this one with @known_git6failure

There were more failures, also probably appropriate, but I'm going to leave this as @wip. Would you run it next time you're in and track down what's happening with the rest of the failures?

Comment #4

sachin2dhoni commented 9 October 2012 at 12:51

Status:	Needs work	» Needs review
Issue tags:		+sprint 12

Uploading to dev branch with fixes and modifications and added few more scenario's accordingly.

Please check the commit log :c23ae59

Comment #5

eliza411 commented 9 October 2012 at 15:42

Version:	6.x-1.x-dev	» 7.x-1.x-dev
Status:	Needs review	» Patch (to be ported)

These look good in 6.x. I'm tagging them to be brought forward to the 7.x branch. I tried cherry-picking these issue commits, but there's still a missing step definition to hunt down.

http://drupalcode.org/project/doobie.git/commit/2191036

Comment #6

tvn commented 30 October 2012 at 14:36

Version:	7.x-1.x-dev	» 6.x-1.x-dev
Assigned:	sachin2dhoni	» Unassigned
Status:	Patch (to be ported)	» Needs work

There were still 2 files marketplace.feature and marketplace_drupalservices.feature with basically the same content. I rearranged tests (see other issues I opened today) to have file per feature and less tests per file.

http://drupalcode.org/project/doobie.git/commit/a12b67a
http://drupalcode.org/project/doobie.git/commit/ed4da16

There are now 2 files for this issue:
marketplace_services.feature - anon user browsing around Services section
marketplace_categories.feature - anon user using top Categories navigation

_services.feature file looks good to me

_categories.feature still needs work.
We need to test somehow that categories navigation actually works, as in - when you choose some categories list of the organizations changes etc.