Javascript not being inserted ...

Has your theme got the print $closure; in it?

Exactly the same problem.... Any suggestion is welcome!

I'm seeing this on 6.x-dev. Will investigate and report back.

This appears to be a bug where the test for variable_get is inverted in two cases.

I'm attaching a patch against 6.x. It may not apply cleanly against 5.x as there are a couple of other tiny fixes in this patch. If you are experienced with PHP you should be able to apply it manually, it's the two lines in the patch containing "variable_get".

I'm unfamiliar with module bugs; do they usually get cloned if they're present in more than one version?

Committed to Drupal5 branch.

Committed to Drupal6 branch.

I've updated to the current 5.x dev version which has the patch applied, and I have the closure code in the footer, but still no javascript is being inserted, and I can't get the module to work.

I found this http://drupal.org/node/150421#comment-240466 which suggests to put the Analytics code into a block and put the block to the footer of all pages.

Has anyone tried this with any success?

Might it be that simply the variables are wrongly set?
When I look at the config-page it says:
"Define what user roles should not be tracked by Google Analytics."
But the variables (see table variables): googleanalytics_track_* are set to 1 if the checkbox is set and 0 if it's not.
So if one would change the text to:
"Define what user roles should be tracked by Google Analytics."
than it works.

Best regards
Stefan

That's exactly what's happenning. The user role tracking settings for this module are just working the other way round, at least for the roles listed there. User 1 is never tracked which ever has in it. You should either change that frase and leave user 1 out of it or fix the code to work as it used to.

Same here. When I checked all the boxes (for all the roles), it was working...

I change this to critical as this module stops working when updated. Please, either change the frase on settings page or return to former functionality because if you use cvs (as I do) to update your modules from your website, this module just stops working and, what is worst, apparently everything looks the same, so webmaster can be very confused. This means that right now, hundreds of sites using this module, if updated, are not working.

Here's an overview of the problem in the current 5.x dev version:

The settings form for this module asks which Roles NOT to track. If a user checks the "Anonymous" role (role #1) then it sets a variable called "googleanalytics_track_1" to TRUE. This is counter-intuitive because the user just indicated he DOES NOT want to track this role yet the variable name indicates that he does want to track the role. The variable name should be changed to "googleanalytics_notrack_1", to prevent the current bug in the sytem.

The current bug is located in the googleanalytics_track() function:

  foreach (array_keys($account->roles) as $role) {
    if (!variable_get('googleanalytics_track_'. $role, FALSE)) {
      $track = FALSE;
    }
  }

  if ($account->uid == 1 && !variable_get('googleanalytics_track__user1', FALSE)) {
    $track = FALSE;
  }

The above code is assuming that if "googleanalytics_track_1" is set to FALSE, then we should not track this page. This is a good assumption based on the language of the variable, but it is wrong because the variable is set using the exact opposite logic.

I propose that all instances of "googleanalytics_track_" be changed to ""googleanalytics_notrack_" and that the above code be modified to remove the "!" in front of each variable_get() function.

Subscribing - same issue :(

I also get this error: Validation error, please try again. If this error persists, please contact the site administrator.

Same issue - I thought I was going logically insane... I've read that decscription in form dozens of times now, always confirming that I had just read "NOT"... :-)

I faced this problem this morning and faced 2 problems:

1) the not track/track problem

2) I was using a custom theme that was not properly set up to call hook_footer(). Our theme_closure output a standard footer with links, and I updated it with

   $footer = module_invoke_all('footer', $main);
    return implode("\n", $footer) . drupal_get_js('footer').$footer_links;
    

Hope this helps, this problem seems to be documented in multiple tickets.

I posted a patch that fixes the logic here. If you guys would mind setting it to RTBC, I could commit it there, and then take a look at the Drupal 5 port of the patch.

I tried your patch for drupal 6 and think is RTBC. Would you port it to drupal 5?