Posted by larowlan on September 20, 2012 at 8:51pm
11 followers
Jump to:
| Project: | Drupal core |
| Version: | 8.x-dev |
| Component: | comment.module |
| Category: | task |
| Priority: | normal |
| Assigned: | larowlan |
| Status: | closed (duplicate) |
| Issue tags: | Platform Initiative |
Issue Summary
This is a meta to flag that work is underway to port comment module to field api.
Sandbox is here: http://drupal.org/sandbox/larowlan/1790736
Advantages
- Will break comment dependency on node
- Will break node dependency on comment ({node}.comment in node_schema())
- Comments on any entity
- Multiple comment fields on an entity. Eg for and against comments. Comments by admin (hidden with field permissions) and comments by public (perfect for commerce orders etc).
Ping me on irc if you want commit access @larowlan.
Work is taking place in the comment-fieldapi branch.
Commits messages are very verbose and indicate current status.
Comments
#1
This would be very useful! Comments on users out of box...
It seems that db-tables should be changed to allow a table per entity
EDIT: is there any solutions in contrib?
#2
Current plan is to rename nid to entity_id and add entity_type and field_name columns.
node_comment_statistics will become comment_entity_statistics with same changes as comment table.
#3
Not sure that you need some special storage, I think that comment field instance should be Shareable by view mode. I'll update this post with all links to comment issues.
Suppose we should should focus on storage first, then implementation and upgrade path
#4
Updated comment_schema.
Added todos for rest of comment.install port.
Added pseudo code for upgrade path.
http://drupalcode.org/sandbox/larowlan/1790736.git/commit/54b31b5
#5
#6
Yeah, this is a duplicate of #731724: Decouple comment.module from node by turning comment settings into a field