Business-Enterprise Theme is a very modern and professional Drupal theme that is perfect for all sorts of corporate and small business websites.The theme is not dependent on any core theme. Its very light weight with modern look and feel. Business's clean layout and light weight code make it a great theme for small or medium-sized business to get up and running quickly.
Simple and Clean Design
1-column and 2-columns layout
Implementation of JS Slideshow
Drupal standards compliant
Supported standard theme features: site logo, site name, site slogan, user pictures in comments, User pictures in nodes, favicon
Git repository:
git clone http://git.drupal.org/sandbox/shanidkv/1843836.git business_enterprises
Project page:
https://drupal.org/sandbox/shanidkv/1843836
Reviews of other projects:
https://drupal.org/node/1826698
https://drupal.org/node/1683924
https://drupal.org/node/1825394
http://drupal.org/node/1516436
http://drupal.org/node/1838644
http://drupal.org/node/1826698
https://drupal.org/node/1624760
https://drupal.org/node/1788704
https://drupal.org/node/1713614
Comment | File | Size | Author |
---|---|---|---|
#29 | sniffer-result.txt | 844 bytes | klausi |
#26 | Coder Sniffer.png | 22.86 KB | zymphonies-dev |
#21 | git.png | 49.54 KB | zymphonies-dev |
#19 | git_issues.png | 66.22 KB | zymphonies-dev |
#19 | file_size.png | 79.21 KB | zymphonies-dev |
Comments
Comment #1
pradbabu CreditAttribution: pradbabu commentedHi Shanidkv,
1) Please change "shanidkv@git.drupal.org:sandbox/shanidkv/1781600.git" to
http://git.drupal.org/sandbox/shanidkv/1781600.git
2. As per http://drupal.org/node/1015226, master branch should not be used. Create a branch named '7.x-1.x' and you can work on it.
3. Also, running your code through automated code review:
http://ventral.org/pareview/httpgitdrupalorgsandboxshanidkv1781600git
4. It would be great, if you could upload a screenshot of your theme in the page.
5. There is a file 'desktop.ini' in your repository. Please remove it or ignore it, before committing.
6. It's a best practice to attribute the source for images used, and the superfish plugins used.
Comment #1.0
zymphonies-dev CreditAttribution: zymphonies-dev commentedgit url
Comment #2
zymphonies-dev CreditAttribution: zymphonies-dev commentedComment #3
zymphonies-dev CreditAttribution: zymphonies-dev commentedHi,
Please change "shanidkv@git.drupal.org:sandbox/shanidkv/1781600.git" to
http://git.drupal.org/sandbox/shanidkv/1781600.git --fixed
As per http://drupal.org/node/1015226, master branch should not be used. Create a branch named '7.x-1.x' and you can work on it. --fixed
It would be great, if you could upload a screenshot of your theme in the page.--fixed
There is a file 'desktop.ini' in your repository. Please remove it or ignore it, before committing.--fixed
Thanks
shanidkv
Comment #4
zymphonies-dev CreditAttribution: zymphonies-dev commentedHi,
I fixed most of the problems, but something like following I do not know how to fix.
107 | ERROR | Files must end in a single new line character (these error is coming for css/js/php file)
20 | ERROR | CASE keyword must be followed by a single space ( JavaScript error)
20 | ERROR | Blank lines are not allowed after CASE statements ( JavaScript error)
20 | ERROR | Inline control structures are not allowed ( JavaScript error)
Screenshot attached
thanks
shanidkv
Comment #5
zymphonies-dev CreditAttribution: zymphonies-dev commentedHi,
I have fixed all errors.
http://ventral.org/pareview/httpgitdrupalorgsandboxshanidkv1781600git
Comment #6
zymphonies-dev CreditAttribution: zymphonies-dev commentedHi,
I have fixed all errors.
please review
http://ventral.org/pareview/httpgitdrupalorgsandboxshanidkv1781600git
thanks
shanidkv
Comment #7
anil614sagar CreditAttribution: anil614sagar commented+1, Looks good ! Marking as RTBC.
Comment #8
anil614sagar CreditAttribution: anil614sagar commentedCame across couple of Javascript errors found using firebug. Needs to be fixed !
Uncaught SyntaxError: Unexpected token ) superfish.js:35
has no method 'superfish' effects.js:4 Marking it as needs work !Uncaught TypeError: Object #
Comment #9
zymphonies-dev CreditAttribution: zymphonies-dev commentedHi Anil,
Fixed Javascript error. please review
thanks
shanid kv
Comment #10
klausiRestoring project application status.
We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)
Comment #11
zymphonies-dev CreditAttribution: zymphonies-dev commentedHi klausi,
sure, i will review your projects.
thanks
Shanid kv
Comment #12
zymphonies-dev CreditAttribution: zymphonies-dev commentedHi,
Fixed all issues.
Can you please review the code, Let me know if you find any error.
thanks
shanid kv
Comment #12.0
zymphonies-dev CreditAttribution: zymphonies-dev commentedclone url
Comment #13
zymphonies-dev CreditAttribution: zymphonies-dev commentedAdded tag: PAReviews: review bonus as outlined on http://drupal.org/node/1410826
Comment #14
bhosmer CreditAttribution: bhosmer commentedNice job. Marking as RTBC.
Comment #15
klausiRemoving review bonus tag, you have not done any manual review, you just posted the output of an automated review tool. Make sure to read through the source code of the other projects.
Comment #16
zymphonies-dev CreditAttribution: zymphonies-dev commentedsure, i will review some other theme projects
Comment #16.0
zymphonies-dev CreditAttribution: zymphonies-dev commentedReviews of other projects
Comment #17
zymphonies-dev CreditAttribution: zymphonies-dev commentedAdding "PAReview: review bonus" tag.
Comment #18
klausiThis automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.
manual review:
"><script>alert('XSS');</script>
as twitter of facebook user name in the theme settings I get a nasty javascript popup. You need to sanitize user provided input before printing. Please read http://drupal.org/node/28984 again.Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.
Comment #19
zymphonies-dev CreditAttribution: zymphonies-dev commentedi stuck with git push issue. i am not able to push to live.
21 MB come from .git hidden folder (.git\objects\pack)
Recently i was formatted my system files
can you help me how to fix these git problems
thanks
shanidkv
Comment #20
bhosmer CreditAttribution: bhosmer commentedFrom your screenshot, it looks like you have a typo where you are trying to push to 7xx-1.x, but your git repo in your sandbox has a branch that is called 7.x-1.x
What does the output of
git remote -v
show?Comment #21
zymphonies-dev CreditAttribution: zymphonies-dev commentedI tried with
git push origin 7.x-1.x
. still have issue ( screenshot attached )Comment #22
bhosmer CreditAttribution: bhosmer commentedYou're trying to push over http, and I suspect you are using a non-maintainer. You need to use your maintainer link which should have the format of shanidkv@git.drupal.org:sandbox/shanidkv/1781600.git
You've cloned the public and can't push to that. You need to use the maintainer link for your origin.
Do this:
Edit:
To answer your question about git remote -v, it shows where your remote is. Origin is a shortcut so you don't have to type the full address. It tells you how you are authenticating and what origin is actually linked to.
Comment #23
zymphonies-dev CreditAttribution: zymphonies-dev commentedIts working fine now :) thanks for your support
Can you help me how to reduce .git hidden file size ( explained in #19 comment with screenshot )
https://drupal.org/files/file_size.png
Comment #24
bhosmer CreditAttribution: bhosmer commentedYou must have had some binary files or something in your repo at one point. I do remember when I cloned your repo, it took a long time.
This might help shed some light on your issue:http://stackoverflow.com/questions/1029969/why-is-my-git-repository-so-big
Comment #25
zymphonies-dev CreditAttribution: zymphonies-dev commented@bhosmer
yes, i tried with those all steps but still have same file size
Comment #25.0
zymphonies-dev CreditAttribution: zymphonies-dev commentedPAReview: review bonus
Comment #26
zymphonies-dev CreditAttribution: zymphonies-dev commented@klausi
Fixed all Coder Sniffer issues (screenshot attached)
1) 21 MB come from .git hidden folder (.git\objects\pack\.pack) -- still i didn't get the proper solution to fix
2) Removed all 3rd party JS files (suggested to use superfish and Nivo slider module)
3) Fixed
4) removed social links code (awesome social links modules are available in drupal.org)
Comment #27
zymphonies-dev CreditAttribution: zymphonies-dev commentedreduced git file size. i have created new git (524 KB)
please review
Comment #27.0
zymphonies-dev CreditAttribution: zymphonies-dev commentedGit url changes
Comment #28
zymphonies-dev CreditAttribution: zymphonies-dev commentedReviewed 3 projects
Added tag: PAReviews: review bonus as outlined on http://drupal.org/node/1410826
Comment #29
klausiThere is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.
manual review:
But that are not blockers, otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.
Comment #30
zymphonies-dev CreditAttribution: zymphonies-dev commentedHi klausi,
1) fixed http://ventral.org generated errors
2) removed unwanted info file
3) fixed doc blocks hook implementations.
Please review
thanks
shanidkv
Comment #30.0
zymphonies-dev CreditAttribution: zymphonies-dev commented3 issues review
Comment #31
zymphonies-dev CreditAttribution: zymphonies-dev commentedAdded tag: PAReviews: review bonus
Reviewed 3 more projects and added sandbox url in summary
https://drupal.org/node/1624760
https://drupal.org/node/1788704
https://drupal.org/node/1713614
Comment #32
klausiNo objections for more than a week, so ...
Thanks for your contribution, shanidkv!
I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #33
zymphonies-dev CreditAttribution: zymphonies-dev commentedThank you for all the reviews :)
Comment #34.0
(not verified) CreditAttribution: commented3 more manual review