Formfilter mangles CCK's "Manage fields" screen
dkruglyak - September 28, 2007 - 01:48
| Project: | Formfilter |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | needs work |
Description
The title says it all. Create a group, add a field to a group and watch it disappear from the manage tab.
Looks like there is a bug in the theming function, theme_content_admin_field_overview_form, in content_admin.inc. Quick dpm on $form array shows that groups are not passed in #table array, which is the only one being themed.
This used to work, so I hope this could get fixed quickly... The problem makes groups unmanageable.
#1
This bug is all about groups, so filing under fieldgroup.module
#2
OK, the above issue results from turning on formfilter's nodeform simplification option.
The reason is that CCK generates a dummy form in Formfilter mangles CCK's "Manage fields" screen.
Possible fix would be to simplify node form only if a path condition holds (like in block visibility).
#3
Yes. I'd welcome a patch. I believe CCK head now includes a property that's added to the node to indicate it's being loaded as a dummy form. Until that reaches stable, we could test for
arg(0) != 'admin'.#4
Draft patch, untested.
#5
No, it didn't work.
But here is another temporary patch which I've tested to work.
Amnon
-
Professional: Drupal Israel | Drupal Development & Consulting | Effective Hosting Strategies | בניית אתרים
Personal: Hitech Dolphin: Regain Simple Joy :)
#6
It's not only group fields. This patch also fixes the state where imagefields disappear.
#7
Thanks for the patch.
The cck_dummy_node_form property is now in CCK's stable release, so we should use it. See the comment in my patch, above.
Could you please give more details about this additional issue? On which form or forms does it appear? Thanks.
#8
This is still an issue in the release branch 5.x-1.0. The above patch works, can we apply this so we can use CCK? Has this been applied to Dev?
#9
subscribe
#10
I was seeing that the $form parameter for formfilter_form_alter has a cck_dummy_node_form set by the CCK manage fields admin screen as $form['#node']->cck_dummy_node_form (true).. seems like this would be a better pattern than checking only if arg(0)==admin ..