The title says it all. Create a group, add a field to a group and watch it disappear from the manage tab.

Looks like there is a bug in the theming function, theme_content_admin_field_overview_form, in content_admin.inc. Quick dpm on $form array shows that groups are not passed in #table array, which is the only one being themed.

This used to work, so I hope this could get fixed quickly... The problem makes groups unmanageable.

CommentFileSizeAuthor
#5 formfilter-cck.patch536 bytesdruvision
#4 formfilter-cck-admin.patch1.17 KBnedjo

Comments

dkruglyak’s picture

dkruglyak commented
Component: General » fieldgroup.module

This bug is all about groups, so filing under fieldgroup.module

dkruglyak’s picture

dkruglyak commented
Title: "Manage fields" screen does not show groups / grouped fields » Formfilter mangles CCK's "Manage fields" screen
Project: Content Construction Kit (CCK) » Formfilter
Component: fieldgroup.module » Code
Category: bug » task
Priority: Critical » Normal

OK, the above issue results from turning on formfilter's nodeform simplification option.

The reason is that CCK generates a dummy form in Formfilter mangles CCK's "Manage fields" screen.

Possible fix would be to simplify node form only if a path condition holds (like in block visibility).

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Yes. I'd welcome a patch. I believe CCK head now includes a property that's added to the node to indicate it's being loaded as a dummy form. Until that reaches stable, we could test for arg(0) != 'admin'.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new formfilter-cck-admin.patch1.17 KB

Draft patch, untested.

druvision’s picture

druvision commented
StatusFileSize
new formfilter-cck.patch536 bytes

No, it didn't work.

But here is another temporary patch which I've tested to work.

Amnon
-
Professional: Drupal Israel | Drupal Development & Consulting | Effective Hosting Strategies | בניית אתרים
Personal: Hitech Dolphin: Regain Simple Joy :)

druvision’s picture

druvision commented

It's not only group fields. This patch also fixes the state where imagefields disappear.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Needs review » Needs work

Thanks for the patch.

The cck_dummy_node_form property is now in CCK's stable release, so we should use it. See the comment in my patch, above.

This patch also fixes the state where imagefields disappear.

Could you please give more details about this additional issue? On which form or forms does it appear? Thanks.

MartysMind’s picture

MartysMind commented
Category: task » bug
Priority: Normal » Critical

This is still an issue in the release branch 5.x-1.0. The above patch works, can we apply this so we can use CCK? Has this been applied to Dev?

momper’s picture

momper commented

subscribe

reubenavery’s picture

reubenavery commented

I was seeing that the $form parameter for formfilter_form_alter has a cck_dummy_node_form set by the CCK manage fields admin screen as $form['#node']->cck_dummy_node_form (true).. seems like this would be a better pattern than checking only if arg(0)==admin ..

pianomansam’s picture

pianomansam commented
Status: Needs work » Closed (won't fix)

Cleaning up old issues. D5 release is no longer supported.