action_workflow_execute_transition() "demotes" workflow state in some cases

this will probably be difficult to reproduce without the specific workflow permissions configuration used where this bug manifests. but i think i can explain it clearly enough anyway.

the logic for changing a workflow state to the 'next' state (which is what this action does) relies on the order of elements returned by workflow_field_choices($node)

Say you have 3 workflow states: one, two, three.

You want to "promote" the state of a node from "two" to "three".

The code in action_workflow_execute_transition() loops through the array returned by workflow_field_choices($node) and when it matches the current state, it then sets the new state to the next element in the array.

However, in my test case, the current workflow state is not included in the array returned by workflow_allowable_transitions().

<?php
  $transitions = workflow_allowable_transitions($current_sid, 'to', $roles);
?>

at this point our current 'two' state is not in $transitions and is therefore prepended with the following code:

<?php
  if ($current_sid != _workflow_creation_state($wid)) { // include current state if not (creation)
    $transitions = array($current_sid => $states[$current_sid]) + $transitions;
  }
?>

So the $transisitons array ends up looking like this:

Array
(
    [N] => Two
    [N] => One
    [N] => Three
)

Now when action_workflow_execute_transition() matches the current state of 'Two', it sets the new state to the next element of the array, which is 'One'.