Need tests for _update_message_text()

Found this bug too. Nice solution ;)

Still needs tests.

I can do this.

I tried:
enabling ui translation
adding a language
going to the updates report and checking manually with the language in the url, for example: af/admin/reports/updates
But I'm not getting the error.

Looks like I might need to go somewhere that causes the
$text .= ' ' . t('See the <a href="@available_updates">available updates</a> page for more information and to install your missing updates.', array('@available_updates' => url('admin/reports/updates/update', array('language' => $language))), array('langcode' => $langcode));
to get used.

Comments on the function say

 * Returns the appropriate message text when site is out of date or not secure.
 *
 * These error messages are shared by both update_requirements() for the
 * site-wide status report at admin/reports/status and in the body of the
 * notification e-mail messages generated by update_cron().

Ok. So I try: af/admin/reports/status
There is no error, and also, the link is generated ok.
It's also ok for admin/reports/status

I'll try adding a contrib module.

I also tried:
dropping db tables
sudo rm -r sites; git checkout sites;
getting spark and putting it in modules
enabling the spark demo

no error, even when visiting admin/reports/status

enable ui translation
adding a language
going to af/admin/reports/status

no error.

I guess I need steps to reproduce. (there is some history of my env being different from webchick's .. and Sutharsan's)

I wont get back to this, at least until tonight.

difficult bug to recreate..
_update_message_text() is only called with a value in the 4th parameter which is $langcode from update_mail()
_update_message_text() is also called from update.install but only with 3 parameters ($langcode = NULL) and therefore empty.
(see http://api.drupal.org/api/drupal/core%21modules%21update%21update.module...)

i think this test can only be triggered by a site generated email and will only ever show up in a server log file.
using dpm($langcode) before and after the patch shows that it is _always_ NULL when $langcode is included in the URL such as YesCT's testing /af/admin/reports/status

Hm. Somehow it does show up in Drupal 8 Spark builds on install. Except now webchick added this patch to the build there :) If you roll it back before you install, it should show up with display errrors on hopefully.

amending issue title..

i could not proceed with installing Spark profile because it depends on ckeditor but there is not an 8.x version of ckeditor in the git repo (that i can locate with my novice contribution skills, sorry)

whilst i agree with webchick and Gábor that this error can be reproduced by installing Spark (because the update module is part of the install profile and the entire module file is parsed for PHP errors) i still think that the _patch_ cannot be tested (during installation) because there is only ever 1 language enabled during installation and therefore !empty($langcode) will never be TRUE ?

i assume we have to find a way to trigger the site-generated email when at least 2 languages are enabled and an enabled contrib module has a newer version available. The $langcode value should be included in the url generated when these conditions are met (or however url() is handling the $language and $langcode parameters).

Test setup:

• en is the system default language and en-gb is installed as a 2nd language.
• i already had installed the devel module so i just edited the devel.info file to amend the version string to "8.x-0.0" as i thought this would be enough to trigger the update warnings in the email response.

i was able to generate this email message invoked from a drush script.. BEFORE applying the patch
pls see attached screenshot..

script:

#!/usr/bin/drush

  $module   = 'update';
  $key      = 'test';
  $to       = '##to_email##';  // NOTE: removed for privacy
  $langcode = 'en-gb';
  $params   = array();
  $from     = '##from_email##';  // NOTE: removed for privacy
  $send     = TRUE;

  drupal_mail($module, $key, $to, $langcode, $params, $from, $send);
  drush_print('Test email sent to ' . $to);

enabled all update notifications (not only security updates)
and applied the patch..

joates@cb200:/8.x-dev$ git status -s
 M core/modules/update/update.module
 M sites/default/modules/devel/devel.info
joates@cb200:/8.x-dev$ 

and then i re-ran my drush script..

i don't think this is generating a positive test result :((
but my method may lead someone else into a more suitable way to test this?

.

Anybody else can reproduce this?

Nobody?

With an old version of spark, what were the steps to produce then? Just install? Or did you have to go to a series of pages, which ones?

No error for me. Tried to reproduce on a clean Spark distribution local install

Steps Taken:

• enabling the spark demo
• adding a language
• going to fr/admin/reports/status
• no error on admin/reports/status

For me this happens during a standard install of the latest Drupal 8.x:

However, this is clearly a type-o! It's using the bare word 'langcode' as if it were a constant, however, no constant is defined so it's actually passing the string 'langcode' to that function everytime. Which isn't correct.

This patch fixes the problem for me!

This affects Drupal 8.x, not just Spark.

This was committed in 2013. If we still need to add test coverage it should happen in a follow-up task.