The 'Tracking multiple domains' link under GA Settings > Domains is broken.

CommentFileSizeAuthor
#7 1793658+Update+links+to+Google+Analytics+help+and+reference+pages3.patch18.18 KBhass
#5 1793658+Update+links+to+Google+Analytics+help+and+reference+pages2.patch18.18 KBhass
#4 google_analytics-update-links-1793658-4.patch1.28 KBsteveoliver
#3 google_analytics-update-links-1793658-3.patch1.28 KBsteveoliver
#1 google_analytics-update-links-1793658-1.patch1.32 KBsteveoliver

Comments

steveoliver’s picture

steveoliver commented
StatusFileSize
new google_analytics-update-links-1793658-1.patch1.32 KB

This fixes the broken link in the description of the 'googleanalytics_cross_domains' field.

hass’s picture

hass commented
Status: Needs review » Needs work

We are not using l() for placeholders in translatable strings. This will cause context sensitive problems. The new url should be something with support.google.com

steveoliver’s picture

steveoliver commented
Status: Needs work » Needs review
StatusFileSize
new google_analytics-update-links-1793658-3.patch1.28 KB

More like this?

steveoliver’s picture

steveoliver commented
StatusFileSize
new google_analytics-update-links-1793658-4.patch1.28 KB

Or with Title Case link... to match the destination page.

hass’s picture

hass commented
StatusFileSize
new 1793658+Update+links+to+Google+Analytics+help+and+reference+pages2.patch18.18 KB

There seems to be nearly all links changed. The attached patch should fix all, except the 404 documenation link where I have not been able to find the new link.

Status: Needs review » Needs work

The last submitted patch, 1793658+Update+links+to+Google+Analytics+help+and+reference+pages2.patch, failed testing.

hass’s picture

hass commented
Status: Needs work » Needs review
StatusFileSize
new 1793658+Update+links+to+Google+Analytics+help+and+reference+pages3.patch18.18 KB

Fixed bracket

hass’s picture

hass commented
Status: Needs review » Fixed

http://drupalcode.org/project/google_analytics.git/commit/a67dae5, D7
http://drupalcode.org/project/google_analytics.git/commit/22ae4c3, D6.4
http://drupalcode.org/project/google_analytics.git/commit/a246250, D6.3

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.