views_preprocess_node check for the wrong row_plugin

So, what's going to happen when we move node.views.inc? And why is that necessary at all?

As far as fixing what we have and adding tests, I would say this is good to go. Maybe there is a better way, I'm not sure atm.

I'm told a generic entity row plugin is on the way to solve all our problems :)

#11: drupal-1793696-11.patch queued for re-testing.

Here are a couple of MINOR nitpicks, apart from that, if this passes, or needs a reroll, this is rtbc.

+++ b/core/modules/views/lib/Drupal/views/Tests/Node/RowPluginTest.phpundefined
@@ -0,0 +1,197 @@
+    // Tests with comments enabled.

This is the only one that is Tests, just use Test..

+++ b/core/modules/views/lib/Drupal/views/Tests/ViewTestBase.phpundefined
@@ -154,6 +155,55 @@ protected function helperCompareFunction($a, $b) {
+   * Performs an xpath search on a certain content.

Lose the 'a'.

Patch #20 solves the problem.

+++ b/core/modules/views/lib/Drupal/views/Tests/ViewTestBase.php
@@ -7,6 +7,7 @@
+use DOMDocument;

Is this needed?

+++ b/core/modules/views/views.module
@@ -250,7 +251,7 @@ function views_preprocess_node(&$vars) {
     node_row_node_view_preprocess_node($vars);

Would it be possible (in a follow up) to move this node row preprocessing to noderow::render?

Patch is looking good, just one question:

+++ b/core/modules/views/views.moduleundefined
@@ -235,6 +235,7 @@ function views_plugin_list() {
 function views_preprocess_node(&$vars) {

Shouldn't maybe node.module be providing this now? Doing this in views.module feels slightly dirty. Now that we're in core, stuff like this could move into node?

Well, now this fix is good, We can easily move this in a follow up for sure. Let's do that.

#28: drupal-1793696-28.patch queued for re-testing.

Rerolled after #1770772: Move row_plugin from style_plugin to the main view object got in.

#34: 1793696-34.patch queued for re-testing.

Exposing the test coverage, and making it clear which is the correct patch.

#40: 1793696-34.patch queued for re-testing.

Committed 509cb25 and pushed to 8.x. Thanks!

The test in this patch is currently failing in HEAD.

git revert 509cb25

Or just use this. It was because of #1938380: Let ViewExecutable->preview() return a render array.
I tested this manually.

All RIGHT, that makes alexpott a REAL core committer now! :D

Reverted commit 509cb25. Restoring various metadata.

Oops.

Okay, here's both of those.

+++ b/core/modules/node/tests/modules/node_test_views/test_views/views.view.test_node_row_plugin.ymlundefined
@@ -0,0 +1,56 @@
+human_name: test_node_row_plugin

It should be label I think.

Yay! I'm a real core committer now :)

Committed 587ceeb and pushed to 8.x. Thanks!