Closed (fixed)
Project:
Drupal Commons
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
24 Sep 2012 at 21:22 UTC
Updated:
4 Jan 2014 at 02:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
erikwebb commentedI think this is a good option. Given the number of entities used throughout Commons (incl. nodes and lots of messages), I'd be curious the gain of this. I think #1792666: Use Views Content Cache to optimize performance should be a higher priority than this, but I'm not opposed to this in any way.
We should re-visit this once we have the full functionality implemented so that we can create quantifiable benchmarks.
Comment #2
crimsondryad commentedWe're in the process of starting to test this module on our (non-Commons) sites. When we get it installed on a high traffic one we'll capture the benchmarks and update this issue with results. One of our sites gets 3 million page views a month. Our DB traffic decreased 90% just by turning on anonymous page caching and Views caching. We're planning to use entity cache as an "AND" not an "OR". That site has some complex content types, so it may offer a decent view into what to expect.
Comment #3
erikwebb commentedThe complex content types will make the biggest difference, which Commons doesn't really have. I'm not opposed to this "AND" either, but just want to make sure it's worthwhile.
Comment #4
crimsondryad commentedI asked KarenS about this, entity_cache will cache the entire entity object, which will make pulling ALL content / users more efficient. Views Content Cache will cache the html output. There isn't a conflict with using both modules and while many things will be pulled from Views, some things won't and this will cache most of those things.
Comment #5
erikwebb commentedIt's absolutely an advantage. Anything we can do to optimize Commons out of the gate is great in my book, especially when it has no configuration or side effects. I'll go ahead and attach a patch here for argument's sake.
For the record - I recommend Entity Cache for all sites, but I'm just more cautious making sweeping recommendations for an entire distribution.
Comment #6
erikwebb commentedAdding performance tag
Comment #7
ezra-g commentedCommitted. Thanks!
http://drupalcode.org/project/commons.git/commit/c1c5d52