Remove use of form_item() in taxonomy [#17955]

Comment	File	Size	Author
#8	taxonomy.module_4.diff	5.1 KB	drumm
	taxonomy.module_3.diff	4.94 KB	drumm

Comment #1

Bèr Kessels commented 28 February 2005 at 13:05

+1 from me. Untill we have a general confirmation API, we should use something like this.
Furthermore the form_select, instead of an ugly looped selector genreator makes sense.

Log in or register to post comments

Comment #2

dries commented 28 February 2005 at 16:31

All other configuration pages (eg. locale module, menu module, etc.) all use form_item(). I'm likely to drop that bit, and have yet to see the feasability of a 'confirmation API' (it sounds difficult).

(Ber: it is not clear from your review whether you tested the patch or not.)

Log in or register to post comments

Comment #3

Bèr Kessels commented 28 February 2005 at 17:28

Dries, I did not test the patch thouroughly. But from what I have seen and tested, the functionality does not change at all. Only the confirmation page looks more like the others we have.

Off-topic: Some handbook page with a test-program might be handy. I, for example have very little professional experience with testing. i just install it and click around a bit, but there must be some good methods.

Log in or register to post comments

Comment #4

dries commented 1 March 2005 at 20:16

Ber: the confirmation page is less like the others we have. What makes you believe it looks more like the others?

Log in or register to post comments

Comment #5

Steven commented 1 March 2005 at 20:22

Btw, I think the "confirmation API" that Bèr was talking about is just a simple form_ function to confirm various stuff in a consistent way. It's pretty simple to do.