I have created a Drupal 7 port of this module inspired by the current code in Drupal 8 which has not been backported yet.

Please add to this project.

I am willing to support/co-maintain if needed.

CommentFileSizeAuthor
#7 1795638-d7-port.patch8.68 KBc31ck
#3 translation_own_nodes-7.x-1.tar_.gz7.27 KBjvizcarrondo
#2 translation_own_nodes.zip9.78 KBrv0
#1 translation_own_nodes.zip9.79 KBrv0
translation_own_nodes.zip9.68 KBrv0

Comments

rv0’s picture

rv0 commented
StatusFileSize
new translation_own_nodes.zip9.79 KB

Forgot a small detail, needed to remove $langcode from node_access

rv0’s picture

rv0 commented
StatusFileSize
new translation_own_nodes.zip9.78 KB

ok more bug fix, took a bit too much of D8 stuff in there, dunno how i overlooked it ;)

jvizcarrondo’s picture

jvizcarrondo commented
StatusFileSize
new translation_own_nodes-7.x-1.tar_.gz7.27 KB

Hi Wim Vanheste.
Much appreciated your help in migrating Translation own nodes to drupal 7.x, check your previous post and had problems with $node->langcode in _translation_own_nodes_tab_access function, I made a rapid development basing on the module code that generated this "Content translation" (translation in drupal core). I tested it and it seems to work, I put it in this post so it can be tested in the future and place it as a version of the module.

As I said before I think your work is greatly appreciated by the users of this module, I have noticed some additional hook that you use in the your code (hook_node_access), I do not understand well to do but I will not have problems in add this feature in the new version if fix a access problem or improvement in some performance module.

grateful

Juan

rv0’s picture

rv0 commented

yeah the langcode thing is what i fixed in #2 i think.

the node access code is taken from D8
i think it is for doing translations with other means than the standard /translate tab. (with a translation helper module or similar)

rv0’s picture

rv0 commented
Status: Needs review » Reviewed & tested by the community

Please commit?

rv0’s picture

rv0 commented
Status: Reviewed & tested by the community » Needs work

I found another typo

Line 49, "translate all content" should be "translate content"
Otherwise the normal translation permission wont work.

c31ck’s picture

c31ck commented
Status: Needs work » Needs review
StatusFileSize
new 1795638-d7-port.patch8.68 KB

I've created a patch against 6.x-1.x based on #2 that:
- Fixes the issue mentioned in #6.
- Fixes some small coding standards violations.
- Cleans up trailing whitespace and missing newlines.

taitai’s picture

taitai commented

The code in #3 will not work
Line 27: return TRUE will disable the whole point of this module. Needs to be commented out.

lklimek’s picture

lklimek commented

I've applied #7 and it seems to work for me (it just lacks proper core version in .info file).

Please create 7.x branch with this :).

toaijala’s picture

toaijala commented

I would like to get a 7.x version of this instead of hacking aswell..

rv0’s picture

rv0 commented
Issue summary: View changes
Status: Needs review » Fixed

I forgot I had gained commit access to this project. Committed. Give it some time to appear on the page.

toaijala’s picture

toaijala commented

I installed the dev package, it works great for me!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.