Download & Extend
Issues

Adding new node link with the same path will hide other links to the same node

Posted by hass on September 29, 2007 at 9:53am
Project:Drupal core
Version:6.x-dev
Component:menu system
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

1. Add one Primary menu item named "Link 1" with path "node/1".
2. Add second Primary menu item named "Link 2" with path "node/1".
3. Menu item named "Link 1" is removed and "Link 2" is kept

If i do the same with "" the "Link 1" is not deleted.

Login or register to post comments

Comments

#1

Posted by pwolanin on September 30, 2007 at 3:38am

I'll take a look - in D6 you should be able to create multiple links to the same path (if you really want to)

#2

Posted by pwolanin on September 30, 2007 at 3:47am

ok, I can reproduce this with a node link, but menu module will happily add two links to ''

#3

Posted by pwolanin on September 30, 2007 at 3:53am

ah, all the node links are in the DB table, they are just not being displayed for some reason! So the initial description of the bug is wrong - a new link is created with a new mlid, but for some reason only one of the two (or more) links is displayed.

#4

Posted by pwolanin on September 30, 2007 at 4:07am
Status:active» needs review

the bug is in function menu_tree_collect_node_links() and function menu_tree_check_access().

patch attached, seems to fix the problem in a reasonable way.

AttachmentSizeStatusTest resultOperations
multi-node-links-179578-4.patch1.21 KBIgnored: Check issue status.NoneNone

#5

Posted by pwolanin on September 30, 2007 at 4:09am
Title:Adding new menu item with same path will delete other item» Adding new node link with the same path will hide other links to the same node

#6

Posted by chx on September 30, 2007 at 4:12am
Status:needs review» reviewed & tested by the community

yes, this works well. we can change the node_links array as we want because it's only used at these two places.

#7

Posted by hass on September 30, 2007 at 12:15pm

Patch works for me, too.

#8

Posted by Gábor Hojtsy on October 1, 2007 at 9:53am
Status:reviewed & tested by the community» fixed

Thanks, committed.

#9

Posted by Anonymous on October 15, 2007 at 10:02am
Status:fixed» closed (fixed)