Hi all, first of all thanks sanduhrs for creating & maintaining this module. I love it!

I'm currently working on a site that will use this module and I wanted to be able to serve hi-res versions of my images for Retina/High-Density displays. As this is implemented in newer versions (v1.5+) of the standalone adaptive image script, I simply merged the changes into the module and it's working nicely. The images look amazing on my test device, an iPod touch 4g. Combined with a few svg replacements in my CSS thanks to Modernizr, everything looks as sharp as a tack.

Patch to follow as soon as I get it created successfully.

CommentFileSizeAuthor
#1 adaptive_image-retina-1796146-2.patch4.21 KBkris_mcl

Comments

kris_mcl’s picture

kris_mcl commented
Status: Active » Needs review
StatusFileSize
new adaptive_image-retina-1796146-2.patch4.21 KB

Here is my patch for the above feature request. The code now attempts to determine the device's pixel aspect ratio and includes that info in the cookie that gets set. Hopefully this comes in handy for someone else as well.

I hope this patch works as I'm not an expert with Git.

kris_mcl’s picture

kris_mcl commented
Issue summary: View changes

Spelling.

jkingsnorth’s picture

jkingsnorth commented
Issue summary: View changes

I haven't had a chance to test this patch yet, but retina support is desperately needed on this module. I've had to disable the module since it was actually reducing the quality of images on retina display devices.

baysaa’s picture

baysaa commented
Status: Needs review » Needs work

The patch in #1 has a missing $ sign in front of one variable.

// if pixel density is not 1, then we need to be smart about adapting and fitting into the defined breakpoints
+        if($pixel_density != 1) {
+          $total_width = $client_width * $pixel_density; // required physical pixel width of the image
+          
+          if ($total_width > $resolutions[0]) {
+            foreach ($resolutions as $break_point) { // filter down
+              if ($total_width <= $break_point) {
+                $resolution = $break_point;
+              }
+            }
+            // now apply the multiplier
+            $resolution = $resolution * pixel_density;

Last line above should read:
$resolution = $resolution * $pixel_density

Other than that, the patch works well. I'm getting high res images on my iPhone 5 and also on iPads and Google Nexus 10 (only with the above fix)