While we have PHP 5.3 as requirement let's change this as @tim.plunket suggests in #1552396-63: Convert vocabularies into configuration

CommentFileSizeAuthor
core-configEB.patch758 bytesandypost

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Issue tags: -Configuration system +Configurables

Can you explain why this is necessary?

::label() always returns something already.

andypost’s picture

andypost
he/him
Primary language Russian
commented

As for me this notation is shorter without loosing readability
::label() could return NULL

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Postponed (maintainer needs more info)

And what's the problem with NULL?

> php -r "var_dump(strnatcasecmp('foo', NULL), strnatcasecmp(NULL, 'foo'), strnatcasecmp(NULL, NULL));"
int(3)
int(-3)
int(0)
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Postponed (maintainer needs more info) » Closed (works as designed)

Sorry, forget it