Undefined index: #required in mothership_form_element()

If I may be picky:

if (!empty($element['#required'])) {

would be better, since $element['#required'] could be set, but set to FALSE.

I think both solutions alter the meaning of the statement:

Let’s say $element['#required'] = TRUE then

if( $element['#required'] ) => TRUE
if(isset($element['#required'])) => TRUE
if (!empty($element['#required'])) => TRUE

If $element['#required'] = FALSE

if( $element['#required'] ) => FALSE
if(isset($element['#required'])) => TRUE
if (!empty($element['#required'])) => TRUE

If $element['#required'] is not set

if( $element['#required'] ) => ERROR
if(isset($element['#required'])) => FALSE
if (!empty($element['#required'])) => TRUE

most sensitive code is imho

if (isset($element['#required']) && $element['#required']) {

yatil: Your middle example, where $element['#required'] = FALSE, is incorrect about the return value of !empty(). If something is set to FALSE, empty() returns TRUE. Since a negation operator (an exclamation mark) is placed before empty(), it will instead return FALSE—not TRUE, like you wrote.

Right, I was wrong :-)

#2 is the right way.

adding a patch for #2 :)

Thanks for patch - had to change line numbers but apart from that it worked for me.

Gem

Tested and can validate this as a fix.

Updated Mojzis's patch #7 with a small spelling fix on the word "required" it was "reguired" before :P

Doesn't look like it was a G to me...?

EDIT: Oh, in the comments. My bad.

Oops did that bad. :D Still fresh to this. Sorry.

Hopefully this one is right.

This is already fixed in the current dev (since september): @see http://drupal.org/commitlog/commit/9436/bc33b09712e38e3e93b496a39014c458...

Good catch, forgot to check Dev. :D Still spelled "required" wrong though with it stil "reguired" hehe

This issue is not fixed as of 7.x-2.10. The simple patch in #7 is the correct way to deal with this.

Although this isn't a big issue, Drupal coding standards dictate PHP should be E_ALL compliant and this causes issues for inexperienced site builders who don't know how to deal with the notice messages.

please test the latest dev version - "works on my machine" ;)