When there are multiple nodes on a page, i.e. node reference or term reference,
the function metatag_entity_view() gets called for every single entity.

To improve the performance, I suggest a static variable is create to avoid doing all the work after the metatags are loaded and stored in $entity->content['metatags'].

CommentFileSizeAuthor
#3 metatag-n1796916-3.patch1.09 KBdamienmckenna
#2 optimize-metatag-entity-view-1796916.patch1007 bytesmarcelovani
#1 optimize-metatag-entity-view-1796916.patch1010 bytesmarcelovani

Comments

marcelovani’s picture

marcelovani
Primary language Portuguese, Brazil
Location London
commented
Status: Active » Needs review
StatusFileSize
new optimize-metatag-entity-view-1796916.patch1010 bytes

Here is the patch

marcelovani’s picture

marcelovani
Primary language Portuguese, Brazil
Location London
commented
StatusFileSize
new optimize-metatag-entity-view-1796916.patch1007 bytes

Re-patched the file. This patch works on current dev version.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n1796916-3.patch1.09 KB

How about this instead - the function already had all of the necessary code, and there's no guarantee that the entities will be loaded in the order your patch assumes.

marcelovani’s picture

marcelovani
Primary language Portuguese, Brazil
Location London
commented

@DamienMcKenna Works well and is much simpler than my solution :)

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: Unassigned » damienmckenna

Will be reviewed next.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Did the tag break?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Fixed » Closed (fixed)

Last night saw the release of 7.x-1.0-beta1, so I'm closing all these "fixed" issues in the interest of tidying up the issue queue. Thank you all for your help getting us to this point!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: damienmckenna » Unassigned
Issue summary: View changes