Problem

  • Automated security audit tools identify the JSON response for switching between image and audio CAPTCHAs as a possible JSON Hijacking attack vector. (which is invalid in Mollom's case)
  • Regardless of that false-alarm, the response to the GET request might be mistakenly cached by poorly configured caches and proxies.

Comments

Status: Needs review » Needs work
Issue tags: +Needs backport to D6

The last submitted patch, mollom.captcha-request-method.0.patch, failed testing.

sun’s picture

Status: Needs work » Needs review
StatusFileSize
new2.15 KB

Adjusted MollomCaptchaTestCase.

Status: Needs review » Needs work

The last submitted patch, mollom.captcha-request-method.2.patch, failed testing.

sun’s picture

Status: Needs work » Needs review
StatusFileSize
new2.56 KB

The built-in drupalPost() method cannot be used here, since it attempts to perform a GET request to the specified URL first, in order to parse and submit a potential form on the target page. Hence, we need to copypaste some internals from the testing framework to facilitate the pure POST request.

Status: Needs review » Needs work

The last submitted patch, mollom.captcha-request-method.4.patch, failed testing.

sun’s picture

Version: 7.x-2.x-dev » 6.x-2.x-dev
Status: Needs work » Needs review
StatusFileSize
new3.04 KB
sun’s picture

Status: Needs review » Fixed

Manually tested for both D7 and D6, and committed to both branches.

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 4d9a189 on 7.x-2.x, 8.x-2.x, fbajs, actions by sun:
    - #1797054 by sun: Use POST instead of GET to switch between image/audio...

  • Commit 4d9a189 on 7.x-2.x, 8.x-2.x, fbajs, actions by sun:
    - #1797054 by sun: Use POST instead of GET to switch between image/audio...