Remove t() from asserts messages in tests for the Field module

I have reviewed each of the proposed message changes in #1 and all are appropriate. Hence, with a green bot response, this is RTBC.

The tests in this module definitely will need another patch to catch the changes to format_string().

This is a big patch @xjm, All of the message changes are appropriate. Hence this is RTBC.

I think some t() asserts were missed in FieldInfoTest.php - I mistakenly first thought that was a new file from the patch mentioned in #3, but it isn't

eg: t("Field type $t_key key $key is $val")

So this is still needs work imo, but I'll let you guys review first. Hopefully by then I get #1040790: _field_info_collate_fields() memory usage green too :)

Ok, nevermind for now, I'm really freaking here.

Ok, so I was not freaking, there are still t() leftovers in there.

Committed to 8.x.

Setting back to needs work so the rest of the assertions can be found/fixed, as per previous comments. Then we need to backport to 7.

oops, forgot status.

Here is a untested patch that I believe cleans up all of the remaining t() removal around assert messages. This is very heavily oriented to changing t() to format_string(), but there are some straight removals as well.

A few more format_string functions required in FieldInfoTest.php. The rest are good.

And #1040790: _field_info_collate_fields() memory usage has been committed for 8.x, so that's okay.

+++ b/core/modules/field/lib/Drupal/field/Tests/FieldInfoTest.php
@@ -38,27 +38,27 @@ class FieldInfoTest extends FieldTestBase {
-        $this->assertEqual($info[$t_key][$key], $val, t("Field type $t_key key $key is $val"));
+        $this->assertEqual($info[$t_key][$key], $val, "Field type $t_key key $key is $val");

-        $this->assertEqual($info[$f_key][$key], $val, t("Formatter type $f_key key $key is $val"));
+        $this->assertEqual($info[$f_key][$key], $val, "Formatter type $f_key key $key is $val");

-        $this->assertEqual($info[$s_key][$key], $val, t("Storage type $s_key key $key is $val"));
+        $this->assertEqual($info[$s_key][$key], $val, "Storage type $s_key key $key is $val");
<code>
-      $this->assertEqual($fields[$field['field_name']]['settings'][$key], $val, t("Field setting $key has correct default value $val"));
+      $this->assertEqual($fields[$field['field_name']]['settings'][$key], $val, "Field setting $key has correct default value $val");

-        $this->assertEqual($info[$t_key][$key], $val, t("Field type $t_key key $key is $val"));

+        $this->assertEqual($info[$t_key][$key], $val, "Field type $t_key key $key is $val");

-        $this->assertEqual($info[$f_key][$key], $val, t("Formatter type $f_key key $key is $val"));

+        $this->assertEqual($info[$f_key][$key], $val, "Formatter type $f_key key $key is $val");

-        $this->assertEqual($info[$s_key][$key], $val, t("Storage type $s_key key $key is $val"));

+        $this->assertEqual($info[$s_key][$key], $val, "Storage type $s_key key $key is $val");

-      $this->assertEqual($fields[$field['field_name']]['settings'][$key], $val, t("Field setting $key has correct default value $val"));

+      $this->assertEqual($fields[$field['field_name']]['settings'][$key], $val, "Field setting $key has correct default value $val");

Thanks for the review @lazysoundsystem. I must have been half-asleep when first editing FieldInfoTest.php.

Here is a corrected patch and interdiff after going through every assert again in that Test file. I think that this corrects all of your comments in #16.

I am wondering if the last four changes in the interdiff are correct. I do not immediately see what are causing the exceptions in #17.

@xjm Thanks for your review. On this machine, I do not have a local test environment for D8. Hence, my patches are untested locally.

The attached patch addresses the comments in #20 and for convenience an interdiff is provided vs #15.

Rerolled #21.

The testing errors are in field tests, so are probably real. (Click "View details" to see them.) Probably a syntax error in the patch -- if you can't find it, post here to ask for help. :)

Rerolled for latest dev + fixed the failing tests. When testing testFieldInfo. The value is an array, when the key is settings.

Reroll was not needed. Patch now with the 2 latest test fixes only.

Sorry about the unneeded reroll. I'm not certain why #21 wouldn't apply for me and I thought it was necessary.

Anyway, I applied #30 and checked all the field tests. I didn't find any more t()'s around assert messages. The patch looks good to me.

Glad to see this RTBC.

Tum te tum...

Committed to 8.x - that's 49 fewer strings for translators to deal with. :) Thanks! Ready for port...

This is a backport of #1 ONLY. It does not include #30 or any additional t() removals that may be needed. The patch is large enough as it is, so I figure it's best to split them up just as the D8 patches were.

This one is a backport of #30.

#37 probably doesn't apply because it expected changes in #36. I'm only re-submitting #36 so the issue turn green and it can get reviewed. Once #36 is committed, #37 can be retested.

I've reviewed #36/#39 and all the changes are good.

I suggest including the changes in #37 and an interdiff, so it could go in as one commit. Otherwise happy to RTBC this part.

#39: 1797106-36-t-field.patch queued for re-testing.

Tagging as Novice.

Rerolled and combined #36 and #37.

#44: 1797106-44-t-field.patch queued for re-testing.

Rerolled #44.

Hi,
this looks good to me
Thanks

Thanks all! Committed to 7.x.