The module should log all messages send with it, successful or not, not just the attempt.

Comments

kbahey’s picture

kbahey commented
Assigned: Unassigned » kbahey
Priority: Critical » Normal

The feedback module is a data conduit, not a data storage module.

The data is taken from the web form, then handed over to the mail server. It is not stored anywhere.

The philosophy for this module is not to use any database changes, and therefore no special tables are created, to keep it simple. This is one reason it is popular: simplicity with functionality.

The reason it logs all attempts is for the site admin's info, for example, to track down how many he got vs. how many were attempted.

nsk’s picture

nsk commented

this means someone may lost important communication. I have lost messages, so I cant use it as it is :(

kbahey’s picture

kbahey commented
Title: log message » Feedback module should save messages

I don't think that person sent you anything.

He or she probably tried to send something, but forgot one of the required fields, or did not enter an email address for himself, and he got an error message on the screen asking him to input the fields he missed, and he did not bother to retry for some reason (perhaps did not want to reveal his email).

Feedback (and Drupal, and any web application for that matter) does not guarantee that anything typed by the user in a web form is saved if missing fields are needed or a validation fails.

Even if the user enters valid information, the mail server may decide not to deliver it for whatever reason (failure, black listing, spam, ....etc.)

So, feedback is no more prone not to deliver than the underlying infrastructure.

kbahey’s picture

kbahey commented

Adding a reference to the original complaint http://drupal.org/node/17907