Posted by xjm

Part of meta #500866: [META] remove t() from assert message.

CommentFileSizeAuthor
#10 interdiff.txt540 bytesdcam
#10 1797286-10-forum-t.patch13.28 KBdcam
#6 1797286-6-forum-t.patch13.28 KBdcam
#1 forum-1797286-1.patch13.74 KBxjm

Comments

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Remove t() from asserts messages in tests for the forum module » Remove t() from assertion messages in tests for the forum module
Assigned: xjm » Unassigned
Status: Active » Needs review
Issue tags: +Needs backport to D7
StatusFileSize
new forum-1797286-1.patch13.74 KB

I had to reformat one of the format_string() replacement lines here because it had so many parens that I couldn't read it myself.

lars toomre’s picture

lars toomre commented
Status: Needs review » Reviewed & tested by the community

I have reviewed each of the changes in this patch and each one of the removal/conversion of t() from test asserts is correct.

With the bot being green, this issue is RTBC!

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

David_Rothstein’s picture

David_Rothstein commented
Version: 8.x-dev » 7.x-dev
Status: Closed (fixed) » Patch (to be ported)

This never made it into Drupal 7.

dcam’s picture

dcam commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 1797286-6-forum-t.patch13.28 KB

Backported #1 to D7.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

#6: 1797286-6-forum-t.patch queued for re-testing.

lazysoundsystem’s picture

lazysoundsystem commented 
-    $this->assertRaw(theme('breadcrumb', array('breadcrumb' => $breadcrumb)), t('Breadcrumbs were displayed'));
+    $this->assertRaw(theme('breadcrumb', array('breadcrumb' => $breadcrumb)), ('Breadcrumbs were displayed'));

No need for parentheses here, otherwise it's all fine.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Needs work
dcam’s picture

dcam commented
Status: Needs work » Needs review
StatusFileSize
new 1797286-10-forum-t.patch13.28 KB
new interdiff.txt540 bytes

Fixed the issue pointed out in #8.

lazysoundsystem’s picture

lazysoundsystem commented
Status: Needs review » Reviewed & tested by the community

Thanks @dcam, this too is good to go. RTBC.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks all! This has been committed to 7.x. Only about 4 more to go!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Removing myself from the author field so I can unfollow. --xjm