When using stylizer in the IPE if you select a style with settings options, on step 2 (panels_edit_style_settings_form) the form will refuse to save if reloaded. In our specific case we're adding preview functionality combined with auto submit. When a preview is generated and the form is reloaded, the reference breaks, causing the data in the settings form to not be properly saved.

The fix is to copy the value from form_state back into the renderer editors cache before the cache is saved. Patch is attached.

CommentFileSizeAuthor
#2 1734772-style-setttings.patch4.64 KBbeeradb
#1 1734772-style-setttings.patch4.64 KBbeeradb
stylizer-form-caching.patch802 bytesbeeradb

Comments

beeradb’s picture

beeradb commented
StatusFileSize
new 1734772-style-setttings.patch4.64 KB

Ignore this patch, I accidentally attached it in the wrong place :)

beeradb’s picture

beeradb commented
StatusFileSize
new 1734772-style-setttings.patch4.64 KB

Ugh. Bad day. Ignore this one too :)

populist’s picture

populist commented
Status: Needs review » Reviewed & tested by the community

This got reviewed in #20 of #1734772: Preview Widget on panels_edit_style_settings_form so marking RTBC.

merlinofchaos’s picture

merlinofchaos commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed the patch in the initial issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 42978af on 7.x-3.x, 7.x-3.x-i18n, 8.x-3.x authored by beeradb, committed by merlinofchaos: 
    Issue #1797298 by beeradb: Fixed Form caching cause references to break...