Part of meta #500866: [META] remove t() from assert message.

CommentFileSizeAuthor
#13 1797328-13-t-image.patch50.82 KBdcam
#9 image-1797328-9.patch51.02 KBdcam
#6 image-1797328-6.patch50.76 KBdcam
#2 image-1797328-2.patch38.57 KBxjm

Comments

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Remove t() from assertion messages in tests for the help module » Remove t() from assertion messages in tests for the image module
Component: help.module » image.module

Guess I accidentally swapped two issues.

xjm’s picture

xjm
she/her
Primary language English
commented
Assigned: xjm » Unassigned
Status: Active » Needs review
StatusFileSize
new image-1797328-2.patch38.57 KB
lars toomre’s picture

lars toomre commented
Status: Needs review » Reviewed & tested by the community

It helps to review issues in detail after some good sleep!! I have reviewed this patch in detail and can confirm that each of these changes to test t() assertion messages are correct. This patch includes some format_string() changes as well which are also correct.

With the bot also being happy, this is RTBC!

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Fixed » Patch (to be ported)

This needs backporting to D7. Also, can someone confirm everything was fixed in D8 and move this back there if not?

dcam’s picture

dcam commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new image-1797328-6.patch50.76 KB

Backported #2 to D7.

dcam’s picture

dcam commented
Issue tags: -Needs backport to D7

#6: image-1797328-6.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Needs backport to D7

The last submitted patch, image-1797328-6.patch, failed testing.

dcam’s picture

dcam commented
Status: Needs work » Needs review
StatusFileSize
new image-1797328-9.patch51.02 KB

Rerolled #6.

dcam’s picture

dcam commented
Issue tags: +Novice

Tagging as Novice.

izus’s picture

izus commented
Issue tags: -Novice, -Needs backport to D7

#9: image-1797328-9.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +Needs backport to D7

The last submitted patch, image-1797328-9.patch, failed testing.

dcam’s picture

dcam commented
Status: Needs work » Needs review
StatusFileSize
new 1797328-13-t-image.patch50.82 KB

Rerolled #9.

izus’s picture

izus commented
Status: Needs review » Reviewed & tested by the community

hi,
the patch looks good :)
thanks

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks for all the retests, rerolls, and reviews! dcam/izus: you are on fire!
Committed to 7.x.

Automatically closed -- issue fixed for 2 weeks with no activity.