Download & Extend
Issues

Remove t() from assertion messages in tests for the openid module

Posted by xjm on September 28, 2012 at 12:30am
Project:Drupal core
Version:7.x-dev
Component:openid.module
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:needs backport to D7

Issue Summary

Part of meta #500866: [META] remove t() from assert message.

Login or register to post comments

Comments

#1

Posted by xjm on September 28, 2012 at 4:52am
Assigned to:xjm» Anonymous
Status:active» needs review
AttachmentSizeStatusTest resultOperations
openid-1797370-1.patch34.2 KBIdlePASSED: [[SimpleTest]]: [MySQL] 41,699 pass(es).View details

#2

Posted by lazysoundsystem on September 28, 2012 at 2:16pm
Status:needs review» reviewed & tested by the community

I've reviewed all the changes and they all look good. RTBC.

#3

Posted by Dries on September 28, 2012 at 2:21pm
Status:reviewed & tested by the community» fixed

Committed to 8.x.

#4

Posted by jhodgdon on September 28, 2012 at 3:34pm
Version:8.x-dev» 7.x-dev
Status:fixed» patch (to be ported)

This needs backporting to D7. Also, can someone confirm everything was fixed in D8 and move this back there if not?

#5

Posted by lazysoundsystem on September 28, 2012 at 3:44pm
Version:7.x-dev» 8.x-dev
Status:patch (to be ported)» fixed

I've checked and can confirm that all the t() functions for messages have been removed from this for 8.x

#6

Posted by jhodgdon on September 28, 2012 at 4:26pm
Version:8.x-dev» 7.x-dev
Status:fixed» patch (to be ported)

OK, we still need to backport to 7.x then. We only want to move back to 8.x if there is still something to be fixed there, and it sounds like there isn't (thanks for checking!).

#7

Posted by lazysoundsystem on September 30, 2012 at 4:59am
Status:patch (to be ported)» needs review

Didn't mean to change the version number, sorry about that. Anyway, here it is, for D7.

AttachmentSizeStatusTest resultOperations
remove_t_from_openid_testsD7-1797370-7.patch29.52 KBIdlePASSED: [[SimpleTest]]: [MySQL] 39,407 pass(es).View details

#8

Posted by dcam on October 18, 2012 at 5:42am
Status:needs review» needs work

One assert message got missed on line 294 of openid.test. @lazysoundsystem if you can make that change then I'll re-test and we can get this committed.

#9

Posted by lazysoundsystem on October 18, 2012 at 9:51am
Status:needs work» needs review

Thanks @dcam, the overlooked t() from #8 is gone now.

AttachmentSizeStatusTest resultOperations
remove_t_from_openid_testsD7-1797370-9.patch29.95 KBIdlePASSED: [[SimpleTest]]: [MySQL] 39,553 pass(es).View details
openid_tests_interdiff.txt596 bytesIgnored: Check issue status.NoneNone

#10

Posted by dcam on October 18, 2012 at 4:03pm
Status:needs review» reviewed & tested by the community

Thanks @lazysoundsystem!

I applied #9 and didn't notice any additional t()'s for removal. The patch looks good to me.

#11

Posted by jhodgdon on October 19, 2012 at 9:50pm
Status:reviewed & tested by the community» fixed

Thanks! This patch has been committed to 7.x.

#12

Posted by System Message on November 2, 2012 at 9:51pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.