Part of meta #500866: [META] remove t() from assert message.

CommentFileSizeAuthor
#9 remove_t_from_openid_testsD7-1797370-9.patch29.95 KBlazysoundsystem
#9 openid_tests_interdiff.txt596 byteslazysoundsystem
#7 remove_t_from_openid_testsD7-1797370-7.patch29.52 KBlazysoundsystem
#1 openid-1797370-1.patch34.2 KBxjm

Comments

xjm’s picture

xjm
she/her
Primary language English
commented
Assigned: xjm » Unassigned
Status: Active » Needs review
StatusFileSize
new openid-1797370-1.patch34.2 KB
lazysoundsystem’s picture

lazysoundsystem commented
Status: Needs review » Reviewed & tested by the community

I've reviewed all the changes and they all look good. RTBC.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Fixed » Patch (to be ported)

This needs backporting to D7. Also, can someone confirm everything was fixed in D8 and move this back there if not?

lazysoundsystem’s picture

lazysoundsystem commented
Version: 7.x-dev » 8.x-dev
Status: Patch (to be ported) » Fixed

I've checked and can confirm that all the t() functions for messages have been removed from this for 8.x

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Fixed » Patch (to be ported)

OK, we still need to backport to 7.x then. We only want to move back to 8.x if there is still something to be fixed there, and it sounds like there isn't (thanks for checking!).

lazysoundsystem’s picture

lazysoundsystem commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new remove_t_from_openid_testsD7-1797370-7.patch29.52 KB

Didn't mean to change the version number, sorry about that. Anyway, here it is, for D7.

dcam’s picture

dcam commented
Status: Needs review » Needs work

One assert message got missed on line 294 of openid.test. @lazysoundsystem if you can make that change then I'll re-test and we can get this committed.

lazysoundsystem’s picture

lazysoundsystem commented
Status: Needs work » Needs review
StatusFileSize
new openid_tests_interdiff.txt596 bytes
new remove_t_from_openid_testsD7-1797370-9.patch29.95 KB

Thanks @dcam, the overlooked t() from #8 is gone now.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Thanks @lazysoundsystem!

I applied #9 and didn't notice any additional t()'s for removal. The patch looks good to me.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks! This patch has been committed to 7.x.

Automatically closed -- issue fixed for 2 weeks with no activity.