Posted by xjm

Part of meta issue #500866: [META] remove t() from assert message.

CommentFileSizeAuthor
#4 shortcut-1797510-4.patch2.15 KBdcam
#1 1797510-1-t-shortcut.patch3.07 KBlars toomre

Comments

lars toomre’s picture

lars toomre commented
Status: Active » Needs review
StatusFileSize
new 1797510-1-t-shortcut.patch3.07 KB

Here is an initial untested patch. It has a format_string() and addresses 4 changes across two test files.

xjm’s picture

xjm
she/her
Primary language English
commented
Assigned: xjm » jhodgdon
Status: Needs review » Reviewed & tested by the community

Another nice simple one.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Assigned: jhodgdon » Unassigned
Status: Reviewed & tested by the community » Patch (to be ported)

Thanks! Committed to 8.x, ready for 7.x port.

dcam’s picture

dcam commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new shortcut-1797510-4.patch2.15 KB

Backported #1 to D7.

dcam’s picture

dcam commented

#4: shortcut-1797510-4.patch queued for re-testing.

dcam’s picture

dcam commented
Issue tags: +Novice

Tagging as Novice.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

#4: shortcut-1797510-4.patch queued for re-testing.

lazysoundsystem’s picture

lazysoundsystem commented
Status: Needs review » Reviewed & tested by the community

This too is good. RTBC.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed to 7.x.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Removing myself from the author field so I can unfollow. --xjm