I placed a logo-rtl.png inside a theme and changed to RTL. But the logo URL hasn't changed. So it looks like RTL support for logo.png is missing.

As example http://www.drupal.org.il/ have a turned RTL druplicon.png on their site and i think this is a reasonable feature.

CommentFileSizeAuthor
#12 179756-12.patch1.28 KBgood_man

Comments

dvessel’s picture

dvessel commented
Version: 6.x-dev » 7.x-dev
Category: bug » feature

Your keyword there is "feature".

hass’s picture

hass commented

But we are adding RTL support to D6... so this should be a bug, while noone have already found this bug.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Actually it would require being able to upload both an LTR and an RTL logo, so it becomes a feature indeed. We need to live with some limitations for D6. Make sure to get these into D7 though.

Freso’s picture

Freso commented

Subscribing. :)

effulgentsia’s picture

effulgentsia commented
Title: RTL support: logo-rtl.png not detected » Add RTL support for logo
Category: feature » bug
Issue tags: +RTL

Time's running out, but I think it makes sense to consider it a bug and still be on the table for D7, if we're claiming that Drupal has good RTL support. Without a patch soon though, it will likely be bumped to D8. Unfortunately, it may get bumped even if a patch does get submitted soon.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

I think others images do not have RTL support either, so its not only about the logo. The logo is even more special in that it has an upload widget on the settings pages, so hass was effectively working around that by using the file system anyway.

good_man’s picture

good_man commented

Is there a feature in D7 for loading -rtl images like css files, or that what are you talking about here? because I don't know what's new in D7 RTL support.

EvanDonovan’s picture

EvanDonovan commented

LTR+RTL logos sounds like a feature, not a bug, since no other images support RTL. If you have an RTL site, you should just upload a logo that is oriented RTL. Then, if you ever change your site back to LTR, change the logo file.

I suppose the only way this could be seen as a bug would be on a multi-lingual site, but even then you could work around it through rules in your page.tpl.php, or else through setting different themes for each language.

EvanDonovan’s picture

EvanDonovan commented
Version: 7.x-dev » 8.x-dev
Category: bug » feature

I'm going to be bold and move this to 8.x, on the basis of the logic from #8.

good_man’s picture

good_man commented

You forgot replacing the logo with logo in CSS, which is my favorite approach for multilingual sites (e.g. adding LTR logo in style.css and RTL logo in style-rtl.css).

I guess we still need to confirm whether this a missing feature from D7 (so it's a bug), or it didn't get into D7 features before (so it's a feature).

EvanDonovan’s picture

EvanDonovan commented

AFAIK, there was not a feature added for this.

good_man’s picture

good_man commented
Status: Active » Needs review
StatusFileSize
new 179756-12.patch1.28 KB

First try, only applies to logo not to all images in the theme.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs review » Needs work

The patch would, at the very least, require API documentation for the hook.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Version: 8.0.x-dev » 8.1.x-dev
Issue summary: View changes

Bumping this to 8.1 because it's a feature addition. Likely needs a field for for the uploader as well.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs work » Postponed (maintainer needs more info)
Issue tags: +stale-issue-cleanup

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

smustgrave’s picture

smustgrave commented

wanted to bump 1 more if this is needed in core?

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.