Closed (fixed)
Project:
Migrate
Version:
7.x-2.4
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
28 Sep 2012 at 08:56 UTC
Updated:
25 Oct 2012 at 00:31 UTC
Hi,
It's the first time I user Migrate module and I'm building a custom module based on BeerTerm example. I found the following code in file "term.inc", function import(), starting with line 127:
// Updating previously-migrated content?
if (isset($row->migrate_map_destid1)) {
$term->tid = $row->migrate_map_destid1; // This line I think is not needed
if (isset($term->tid)) {
if ($term->tid != $row->migrate_map_destid1) { // This will never be true because of the previous marked line
throw new MigrateException(t("Incoming tid !tid and map destination nid !destid1 don't match",
array('!tid' => $term->tid, '!destid1' => $row->migrate_map_destid1)));
}
}
else {
$term->tid = $row->migrate_map_destid1;
}
}
Am I missing something or this is a error?
Comments
Comment #1
mikeryanYeah, that's pretty funky - I'll need to take some time and figure out what it was supposed to be doing there, I imagine along the way a line or two got deleted and left a vestige...
Comment #2
mikeryanLooks like you were right, the assignment at the top was bogus, the rest looks good. Committed, thanks.