A small plugin for context module to allow changing of the main menu (menu_main_links_source) variable through context.

Requires: context, menu

Sandbox: http://drupal.org/sandbox/kpa/1797724
Git repo: git clone --recursive --branch 7.x-1.x http://git.drupal.org/sandbox/kpa/1797724.git context_reaction_main_menu

D7 only

Comments

sanchi.girotra’s picture

sanchi.girotra commented

Hi Phillip,

Please review your module from coder module and see the automated review here.

superspring’s picture

superspring commented

In the file context_reaction_main_menu.module:

Drupal Coding Standards:
- Yes, see the previous comment.
- Simple fixes include: 80 characters per line.
- Extra spaces should be removed
- Comments shouldn't have extra spaces
- Function comments should always start with /**, not /*

In the file context_reaction_main_menu.inc

Suggestions:
- global $conf only needs to be declared once, not inside the loop.
- Use better variable names than $k and $v

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work

Needs work per comment #2.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

papirrin’s picture

papirrin commented

Hi kpa, have you get your code reviewed yet?

kpa’s picture

kpa commented
Status: Needs work » Needs review

Hi all,

It's been a while since I was last able to look at this - was quite a way down on the priority list! I've worked through the issues mentioned though and believe it's ready to be pushed to an actual project :-)

git is at http://git.drupal.org/sandbox/kpa/1797724.git
coder review at http://ventral.org/pareview/httpgitdrupalorgsandboxkpa1797724git - the one remaining issue is due to the context module - the method needs to remain the same in order to override the parent class's method.

Hope some of you can help!

Thanks in advance

pagolo’s picture

pagolo commented

How about a README.txt file?

Matters’s picture

Matters commented

As said pagolo, please add README.txt and delete your .gitignore file

kpa’s picture

kpa commented

Hi all,

I've now added a README.txt and deleted the .gitignore file, as requested.
Thanks

kpa’s picture

kpa commented

Has anyone got time to push this through to full project status please?
Thanks :-)

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Needs review » Reviewed & tested by the community

Looks good!

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Reviewed & tested by the community » Fixed

It's been over a month, and the module still looks good on further review, so...

Thanks for your contribution, kpa!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Enterprise modules from the community for the community.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Title: Context Reaction: Main Menu » [D7] Context Reaction: Main Menu
kpa’s picture

kpa commented
Title: [D7] Context Reaction: Main Menu » [D7] Context Reaction: Menus
Status: Fixed » Closed (fixed)

A few more changes committed, and pushed to a full project :-) Thank you!