Convert node_access_needs_rebuild to state system

Does this need to be brought over from a d7 during upgrade?

+++ b/core/modules/node/node.installundefined
@@ -601,6 +601,15 @@ function node_update_8004() {
+function node_update_8005() {
+  state()->set('node_access_needs_rebuild', update_variable_get('node_access_needs_rebuild', FALSE));
+}

No need to set if node_access_needs_rebuild is false.

Need to also do an update_variable_del() too?

Tested... works as expected.

Reviewers: note that node_access_rebuild is only ever set to TRUE - otherwise it is deleted. That's why in the update_N function the variable is only deleted if it is set to TRUE.

oh... and @tayzlor thanks for the work!

We've decided to namespace the key value names so we need to change the variable name from node_access_needs_rebuild to something else. Perhaps node.node_access_needs_rebuild

Namespaced. I chose to go with node.access_needs_rebuilt to remove the redundancy.

Not sure about node.access_needs_rebuild as node_access is the table that is being rebuilt!... that's why I plumped for node.node_access_needs_rebuild...

Bikeshed anyone? :)

No, definitely no bikeshed. Just thought that was the way it was supposed to be. Here it is with your suggested name.

We have a new function for updating variables to state... update_variables_to_state()

Have a look at system_update_8026() for how to use this.

Also @sun and I have agreed that all state upgrades should just be documented with the same group as config. So...

+++ b/core/modules/node/node.installundefined
@@ -678,6 +678,18 @@ function node_update_8006(&$sandbox) {
+ * @ingroup state_upgrade

Change to @ingroup config_upgrade

Ah, I had been watching #1798732: Convert install_task, install_time and install_current_batch to use the state system but didn't realize that it had landed. Been traveling in Ireland (on a train now from Cork to Dublin, actually). Patch updated.

Can you add to the test in Drupal\system\Tests\Upgrade\StateSystemUpgradePathTest?

You will need to set the value to TRUE using drupal-7.state.system.database.php

db_insert('variable')->fields(array(
  'name',
  'value',
))
->values(array(
  'name' => 'node_access_needs_rebuild',
  'value'=> serialize(TRUE),
));

And then add something like this to the test:

    $expected_state['node.node_access_needs_rebuild'] = array(
      'value' => TRUE,
      'variable_name' => 'node_access_needs_rebuild',
    );

Otherwise looks good!

#15: node_access_needs_rebuild-1798804-15.patch queued for re-testing.

Bumped node_update_N so patch works and moved tests to the state test class so that they work too.

Tests passed, re-roll looks good to me.

Committed and pushed to 8.x. Thanks!