Follow up to #1792374: Cleanup 7.x-2.x code, align to Drupal standards (tier 1 and 2),

Tier 3 - coder - patch to be attached here for review.

CommentFileSizeAuthor
#1 textimage_code-cleanup_1798806-1.patch1.9 KBmondrake

Comments

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
StatusFileSize
new textimage_code-cleanup_1798806-1.patch1.9 KB

Here a patch. Introduces minor changes recommended by coder (use drupal_ string functions, @ placeholders in place of ! in forms, use preg_replace_callback in place of preg_replace). Leaving for a while in 'needs review' status for anyone willing to review.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Fixed

Fixed and pushed to dev, commit 009615a

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.